Page MenuHomeFreeBSD

Don't enable interrupts in init_secondary().
ClosedPublic

Authored by markj on Jan 22 2020, 11:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 28, 3:18 AM
Unknown Object (File)
Mon, Nov 24, 4:45 AM
Unknown Object (File)
Mon, Nov 24, 2:28 AM
Unknown Object (File)
Sun, Nov 23, 8:51 PM
Unknown Object (File)
Thu, Nov 20, 10:53 PM
Unknown Object (File)
Thu, Nov 20, 10:53 PM
Unknown Object (File)
Thu, Nov 20, 10:53 PM
Unknown Object (File)
Thu, Nov 20, 10:46 PM
Subscribers

Details

Summary

Doing so can cause deadlocks or panics during boot. In QEMU I was
seeing occasional panics during boot when a statclock interrupt
interrupted an idle thread in init_secondary(), before per-CPU scheduler
data structures were linked. It also seemed to be causing some
mysterious boot failures in AWS but I don't have console access and so
cannot confirm.

The idle threads are set up to release a spinlock section and enable
interrupts in fork_exit(), so there is no need to enable interrupts
earlier.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28864
Build 26869: arc lint + arc unit