Page MenuHomeFreeBSD
Differential D23328

Don't enable interrupts in init_secondary().
ClosedPublic
Actions

Authored by markj on Jan 22 2020, 11:02 PM.
Tags
None
Referenced Files
F163497544: D23328.diff
Thu, Jul 23, 8:03 PM
Unknown Object (File)
Wed, Jul 22, 3:21 PM
Unknown Object (File)
Tue, Jul 21, 12:47 PM
Unknown Object (File)
Tue, Jul 14, 2:01 PM
Unknown Object (File)
May 7 2026, 7:57 PM
Unknown Object (File)
May 6 2026, 11:43 AM
Unknown Object (File)
May 5 2026, 4:10 PM
Unknown Object (File)
May 3 2026, 11:37 AM
View All 84 Files
Subscribers
andrew
emaste
imp

Details

Reviewers
manu
kib
andrew
Group Reviewers
arm64
Commits
rS357048: arm64: Don't enable interrupts in init_secondary().
Summary

Doing so can cause deadlocks or panics during boot. In QEMU I was
seeing occasional panics during boot when a statclock interrupt
interrupted an idle thread in init_secondary(), before per-CPU scheduler
data structures were linked. It also seemed to be causing some
mysterious boot failures in AWS but I don't have console access and so
cannot confirm.

The idle threads are set up to release a spinlock section and enable
interrupts in fork_exit(), so there is no need to enable interrupts
earlier.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28864
Build 26869: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
6 lines

Diff 67170

View Options

sys/arm64/arm64/mp_machdep.c

Loading...