Provide a single implementation for each of the arm64 ops.
ClosedPublic
Actions

Authored by markj on Jan 22 2020, 8:05 PM.

Details

Reviewers

manu
andrew
kib

Group Reviewers

arm64

Commits

rS357457: Provide a single implementation for each of the arm64 atomic(9) ops.

Summary

Parameterize the macros by type width as well as acq/rel semantics.
This makes modifying the implementations much less tedious and
error-prone and makes it easier to support alternate LSE-based
implementations.

No functional change intended.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28858
Build 26864: arc lint + arc unit

Event Timeline

markj created this revision.Jan 22 2020, 8:05 PM

Herald added a reviewer: manu. · View Herald TranscriptJan 22 2020, 8:05 PM

Herald added subscribers: emaste, andrew. · View Herald Transcript

Harbormaster completed remote builds in B28851: Diff 67155.Jan 22 2020, 8:05 PM

markj added reviewers: andrew, arm64.Jan 22 2020, 8:07 PM

markj added a subscriber: cperciva.

Fix merge issues.

Harbormaster completed remote builds in B28858: Diff 67165.Jan 22 2020, 9:32 PM

andrew accepted this revision.Jan 27 2020, 2:24 PM

This revision is now accepted and ready to land.Jan 27 2020, 2:24 PM

markj added a reviewer: kib.Feb 2 2020, 6:54 PM

kib accepted this revision.Feb 2 2020, 10:10 PM

Closed by commit rS357457: Provide a single implementation for each of the arm64 atomic(9) ops. (authored by markj). · Explain WhyFeb 3 2020, 6:23 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS357457: Provide a single implementation for each of the arm64 atomic(9) ops..

Herald added a subscriber: imp. · View Herald TranscriptFeb 3 2020, 6:23 PM

Revision Contents
Changeset List

Path

Size

sys/

arm64/

include/

atomic.h

632 lines

Diff 67165

View Options

sys/arm64/include/atomic.h

Provide a single implementation for each of the arm64 ops.ClosedPublicActions