Page MenuHomeFreeBSD
Differential D23171

Make linux(4) handle TCP_CORK
ClosedPublic
Actions

Authored by trasz on Jan 14 2020, 12:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 14, 2:01 PM
Unknown Object (File)
Fri, Aug 14, 5:59 AM
Unknown Object (File)
Wed, Aug 12, 9:35 PM
Unknown Object (File)
Fri, Aug 7, 9:40 PM
Unknown Object (File)
Thu, Aug 6, 2:42 PM
Unknown Object (File)
Thu, Aug 6, 12:56 AM
Unknown Object (File)
Wed, Aug 5, 5:39 PM
Unknown Object (File)
Wed, Aug 5, 9:31 AM
View All Files
Subscribers
afedorov
imp

Details

Reviewers
dchagin
emaste
kib
jhb
Group Reviewers
Linux Emulation
Commits
rS357203: Add TCP_CORK support to linux(4). This fixes one of the things Nginx
Summary

Add TCP_CORK support to linux(4). This fixes one of the things Nginx trips over.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28724
Build 26739: arc lint + arc unit

Event Timeline

trasz created this revision.Jan 14 2020, 12:11 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 14 2020, 12:11 PM
Harbormaster completed remote builds in B28660: Diff 66735.Jan 14 2020, 12:11 PM
trasz edited the summary of this revision. (Show Details)Jan 14 2020, 12:11 PM
trasz added reviewers: Linux Emulation, dchagin, emaste, kib.
afedorov added a subscriber: afedorov.Jan 14 2020, 2:52 PM
afedorov added inline comments.
sys/compat/linux/linux_socket.c
243

Is this correct? It seems that linux TCP_CORK works more like FreeBSD TCP_NOPUSH.

trasz added a comment.Jan 16 2020, 3:14 PM

(NB: kern/24959)

trasz updated this revision to Diff 66901.Jan 17 2020, 11:09 AM

Fix thinko pointed out by Alexander.

Harbormaster completed remote builds in B28724: Diff 66901.Jan 17 2020, 11:09 AM
trasz added a reviewer: jhb.Jan 17 2020, 11:10 AM
trasz marked an inline comment as done.Jan 17 2020, 2:15 PM
trasz added a comment.Jan 27 2020, 3:37 PM

Tinderboxed.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 28 2020, 1:57 PM
Closed by commit rS357203: Add TCP_CORK support to linux(4). This fixes one of the things Nginx (authored by trasz). · Explain Why
This revision was automatically updated to reflect the committed changes.
trasz added a commit: rS357203: Add TCP_CORK support to linux(4). This fixes one of the things Nginx.

Revision Contents
Changeset List

PathSize
sys/
compat/
linux/
1 line
2 lines

Diff 66901

View Options

sys/compat/linux/linux_socket.h

Loading...
View Options

sys/compat/linux/linux_socket.c

Loading...