Page MenuHomeFreeBSD
Differential D23208

Remove DSACK debug logging
ClosedPublic
Actions

Authored by rscheff on Jan 16 2020, 4:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 3 2024, 2:54 PM
Unknown Object (File)
Nov 2 2024, 12:38 AM
Unknown Object (File)
Nov 2 2024, 12:38 AM
Unknown Object (File)
Nov 2 2024, 12:38 AM
Unknown Object (File)
Nov 2 2024, 12:18 AM
Unknown Object (File)
Oct 31 2024, 4:51 PM
Unknown Object (File)
Oct 22 2024, 8:21 AM
Unknown Object (File)
Sep 23 2024, 7:16 AM
View All 50 Files
Subscribers
imp
melifaro

Details

Reviewers
rrs
tuexen
jtl
Group Reviewers
transport
Commits
rS362879: MFC r356796:
rS356796: Remove debug code not needed anymore.
Summary

Left dmesg debug logging in the DSACK code.
As the DSACK functionality was thoroughly debugged in the
meantime, this is no longer necessary.

DSACK timeline and required patches so far:

rS347382 (2019-05-09) - initial dirty hack
rS347407 (2019-05-09) - no C++ comments
rS348728 (2019-06-96) - RACK changes
rS349987 (2019-07-14) - send dsack blk only once
rS351725 (2019-09-02) - fully conform with rfc2883
rS351801 (2019-09-02) - fix SACK block generation
rS352072 (2019-09-02) - update dsack only for data segments
rS352386 (2019-09-16) - fix out of bounds write
rS356796 (2020-01-16) - remove debug code (this change)
rS357100 (2020-01-24) - Fix TCP FO

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28701
Build 26719: arc lint + arc unit

Event Timeline

rscheff created this revision.Jan 16 2020, 4:52 PM
Herald added a reviewer: transport. · View Herald TranscriptJan 16 2020, 4:52 PM
Harbormaster completed remote builds in B28701: Diff 66841.Jan 16 2020, 4:52 PM
tuexen accepted this revision.Jan 16 2020, 5:12 PM
This revision is now accepted and ready to land.Jan 16 2020, 5:12 PM
Closed by commit rS356796: Remove debug code not needed anymore. (authored by tuexen). · Explain WhyJan 16 2020, 5:15 PM
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rS356796: Remove debug code not needed anymore..
Herald added a subscriber: imp. · View Herald TranscriptJan 16 2020, 5:15 PM
tuexen edited the summary of this revision. (Show Details)Jan 16 2020, 5:16 PM
tuexen edited the summary of this revision. (Show Details)
tuexen edited the summary of this revision. (Show Details)Apr 24 2020, 6:52 PM
Herald added a subscriber: melifaro. · View Herald TranscriptApr 24 2020, 6:52 PM
tuexen edited the summary of this revision. (Show Details)Apr 24 2020, 6:54 PM
tuexen edited the summary of this revision. (Show Details)Apr 24 2020, 7:07 PM
tuexen mentioned this in rS360282: Improve the TCP SACK generation by reporting DSACKs.Apr 24 2020, 9:30 PM
tuexen added a commit: rS362879: MFC r356796:.Jul 1 2020, 10:31 PM

Revision Contents
Changeset List

PathSize
sys/
netinet/
5 lines

Diff 66841

View Options

sys/netinet/tcp_sack.c

Loading...