Page MenuHomeFreeBSD
Differential D23080

ng_nat: Pass IPv6 packets through.
ClosedPublic
Actions

Authored by markj on Jan 8 2020, 1:14 AM.
Tags
None
Referenced Files
F162939852: D23080.id67212.diff
Sat, Jul 18, 12:43 PM
F162897145: D23080.diff
Sat, Jul 18, 2:57 AM
Unknown Object (File)
Tue, Jul 14, 6:22 PM
Unknown Object (File)
Sat, Jul 11, 6:20 AM
Unknown Object (File)
Jun 18 2026, 3:47 PM
Unknown Object (File)
Jun 4 2026, 4:17 AM
Unknown Object (File)
May 26 2026, 9:23 AM
Unknown Object (File)
May 26 2026, 9:14 AM
View All Files
Subscribers
donner
imp
julian
melifaro

Details

Reviewers
glebius
sobomax
julian
Group Reviewers
manpages
Commits
rS359708: MFC r357053 by markj: ng_nat: Pass IPv6 packets through.
rS359707: MFC r357053 by markj: ng_nat: Pass IPv6 packets through.
rS357053: ng_nat: Pass IPv6 packets through.
Summary

Treating them as though they start with IP headers doesn't go well.

PR: 243096

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28531
Build 26584: arc lint + arc unit

Event Timeline

markj created this revision.Jan 8 2020, 1:14 AM
Herald added a subscriber: donner. · View Herald TranscriptJan 8 2020, 1:14 AM
Harbormaster completed remote builds in B28531: Diff 66473.Jan 8 2020, 1:14 AM
markj added reviewers: glebius, sobomax.Jan 8 2020, 1:15 AM
julian accepted this revision.Jan 8 2020, 4:30 AM
julian added a subscriber: julian.

yes, only ipv4 packets should be processed. what actually exploded?

This revision is now accepted and ready to land.Jan 8 2020, 4:30 AM
markj added a comment.Jan 8 2020, 4:00 PM
In D23080#505838, @julian wrote:

yes, only ipv4 packets should be processed. what actually exploded?

The assertion on line 813. This patch is not sufficient though, see PR 243096.

Closed by commit rS357053: ng_nat: Pass IPv6 packets through. (authored by markj). · Explain WhyJan 23 2020, 4:46 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rS357053: ng_nat: Pass IPv6 packets through..
Herald added a reviewer: manpages. · View Herald TranscriptJan 23 2020, 4:46 PM
Herald added a subscriber: imp. · View Herald Transcript
eugen added a commit: rS359707: MFC r357053 by markj: ng_nat: Pass IPv6 packets through..Apr 7 2020, 5:49 PM
Herald added a subscriber: melifaro. · View Herald TranscriptApr 7 2020, 5:49 PM
eugen added a commit: rS359708: MFC r357053 by markj: ng_nat: Pass IPv6 packets through..Apr 7 2020, 5:50 PM

Revision Contents
Changeset List

PathSize
share/
man/
man4/
2 lines
sys/
netgraph/
1 line

Diff 66473

View Options

share/man/man4/ng_nat.4

Loading...
View Options

sys/netgraph/ng_nat.c

Loading...