rtld(1): Do booleans like C99
ClosedPublic
Actions

Authored by cem on Dec 30 2019, 4:07 AM.

Details

Reviewers

kib
rlibby
jhb

Commits

rS356220: rtld(1): Do booleans like C99

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28374
Build 26460: arc lint + arc unit

Event Timeline

cem created this revision.Dec 30 2019, 4:07 AM

Herald added a subscriber: bdragon. · View Herald TranscriptDec 30 2019, 4:07 AM

Harbormaster completed remote builds in B28374: Diff 66132.Dec 30 2019, 4:07 AM

kib accepted this revision.Dec 30 2019, 9:00 AM

This revision is now accepted and ready to land.Dec 30 2019, 9:00 AM

This one blames to 1998, so I guess it was legit :)

Just curious, what is your aim here? I see a few more of these in the tree. Are you cleaning up specific code of interest or generally trying to C99-ify the tree?

Thanks!

In D22964#503317, @rlibby wrote:

This one blames to 1998, so I guess it was legit :)

Just curious, what is your aim here? I see a few more of these in the tree. Are you cleaning up specific code of interest or generally trying to C99-ify the tree?

In another revision, I added use of bool in an unrelated header that gets included in some rtld CU along with this one, and the two definitions conflict, producing a compilation error. So mostly I'd just like to be able to use C99 bool in other places without breaking rtld.

Closed by commit rS356220: rtld(1): Do booleans like C99 (authored by cem). · Explain WhyDec 31 2019, 5:41 AM

This revision was automatically updated to reflect the committed changes.

cem added a commit: rS356220: rtld(1): Do booleans like C99.

Herald added a subscriber: imp. · View Herald TranscriptDec 31 2019, 5:42 AM