Page MenuHomeFreeBSD
Differential D22885

Remove page locking for queue operations.
ClosedPublic
Actions

Authored by markj on Dec 19 2019, 11:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 14, 11:27 AM
Unknown Object (File)
Sat, Apr 12, 1:51 AM
Unknown Object (File)
Mar 15 2025, 4:40 PM
Unknown Object (File)
Feb 24 2025, 3:45 PM
Unknown Object (File)
Feb 18 2025, 3:13 PM
Unknown Object (File)
Jan 25 2025, 7:56 PM
Unknown Object (File)
Jan 24 2025, 6:56 PM
Unknown Object (File)
Jan 18 2025, 9:04 PM
View All 59 Files
Subscribers
delphij
imp

Details

Reviewers
alc
jeff
kib
dougm
Commits
rS356157: Remove page locking for queue operations.
Summary

With the previous reviews, the page lock is no longer required in order
to perform queue operations on a page. It is also no longer needed in
the page queue scans.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
head/
sys/
cddl/
contrib/
opensolaris/
uts/
common/
fs/
zfs/
4 lines
2 lines
dev/
md/
7 lines
fs/
tmpfs/
2 lines
kern/
2 lines
vm/
9 lines
30 lines
7 lines
8 lines
13 lines
177 lines
2 lines

Diff 66067

View Options

head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu.c

Show First 20 Lines • Show All 112 Lines • ▼ Show 20 Lines
/* /*
* Read the specified part of a file to kernel space. Unlike regular * Read the specified part of a file to kernel space. Unlike regular
* pread, the file pointer is advanced to the end of the read data, * pread, the file pointer is advanced to the end of the read data,
* and it just returns 0 if successful. * and it just returns 0 if successful.
*/ */
int int
kern_pread(int fd, vm_offset_t dest, size_t len, off_t off) kern_pread(int fd, vm_offset_t dest, size_t len, off_t off)
{ {
ssize_t nread;
if (lseek(fd, off, SEEK_SET) == -1) { if (lseek(fd, off, SEEK_SET) == -1) {
#ifdef DEBUG #ifdef DEBUG
printf("\nlseek failed\n"); printf("\nlseek failed\n");
#endif #endif
return (-1); return (-1);
} }
nread = archsw.arch_readin(fd, dest, len); if ((size_t)archsw.arch_readin(fd, dest, len) != len) {
if (nread != len) {
#ifdef DEBUG #ifdef DEBUG
printf("\nreadin failed\n"); printf("\nreadin failed\n");
#endif #endif
return (-1); return (-1);
} }
return (0); return (0);
} }
/* /*
* Read the specified part of a file to a malloced buffer. The file * Read the specified part of a file to a malloced buffer. The file
* pointer is advanced to the end of the read data. * pointer is advanced to the end of the read data.
*/ */
void * void *
alloc_pread(int fd, off_t off, size_t len) alloc_pread(int fd, off_t off, size_t len)
{ {
void *buf; void *buf;
ssize_t nread;
buf = malloc(len); buf = malloc(len);
if (buf == NULL) { if (buf == NULL) {
#ifdef DEBUG #ifdef DEBUG
printf("\nmalloc(%d) failed\n", (int)len); printf("\nmalloc(%d) failed\n", (int)len);
#endif #endif
return (NULL); return (NULL);
} }
if (lseek(fd, off, SEEK_SET) == -1) { if (lseek(fd, off, SEEK_SET) == -1) {
#ifdef DEBUG #ifdef DEBUG
printf("\nlseek failed\n"); printf("\nlseek failed\n");
#endif #endif
free(buf); free(buf);
return (NULL); return (NULL);
} }
nread = read(fd, buf, len); if ((size_t)read(fd, buf, len) != len) {
if (nread != len) {
#ifdef DEBUG #ifdef DEBUG
printf("\nread failed\n"); printf("\nread failed\n");
#endif #endif
free(buf); free(buf);
return (NULL); return (NULL);
} }
return (buf); return (buf);
} }
▲ Show 20 Lines • Show All 51 Lines • Show Last 20 Lines
View Options

head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c

Show First 20 Lines • Show All 112 Lines • ▼ Show 20 Lines
/* /*
* Read the specified part of a file to kernel space. Unlike regular * Read the specified part of a file to kernel space. Unlike regular
* pread, the file pointer is advanced to the end of the read data, * pread, the file pointer is advanced to the end of the read data,
* and it just returns 0 if successful. * and it just returns 0 if successful.
*/ */
int int
kern_pread(int fd, vm_offset_t dest, size_t len, off_t off) kern_pread(int fd, vm_offset_t dest, size_t len, off_t off)
{ {
ssize_t nread;
if (lseek(fd, off, SEEK_SET) == -1) { if (lseek(fd, off, SEEK_SET) == -1) {
#ifdef DEBUG #ifdef DEBUG
printf("\nlseek failed\n"); printf("\nlseek failed\n");
#endif #endif
return (-1); return (-1);
} }
nread = archsw.arch_readin(fd, dest, len); if ((size_t)archsw.arch_readin(fd, dest, len) != len) {
if (nread != len) {
#ifdef DEBUG #ifdef DEBUG
printf("\nreadin failed\n"); printf("\nreadin failed\n");
#endif #endif
return (-1); return (-1);
} }
return (0); return (0);
} }
/* /*
* Read the specified part of a file to a malloced buffer. The file * Read the specified part of a file to a malloced buffer. The file
* pointer is advanced to the end of the read data. * pointer is advanced to the end of the read data.
*/ */
void * void *
alloc_pread(int fd, off_t off, size_t len) alloc_pread(int fd, off_t off, size_t len)
{ {
void *buf; void *buf;
ssize_t nread;
buf = malloc(len); buf = malloc(len);
if (buf == NULL) { if (buf == NULL) {
#ifdef DEBUG #ifdef DEBUG
printf("\nmalloc(%d) failed\n", (int)len); printf("\nmalloc(%d) failed\n", (int)len);
#endif #endif
return (NULL); return (NULL);
} }
if (lseek(fd, off, SEEK_SET) == -1) { if (lseek(fd, off, SEEK_SET) == -1) {
#ifdef DEBUG #ifdef DEBUG
printf("\nlseek failed\n"); printf("\nlseek failed\n");
#endif #endif
free(buf); free(buf);
return (NULL); return (NULL);
} }
nread = read(fd, buf, len); if ((size_t)read(fd, buf, len) != len) {
if (nread != len) {
#ifdef DEBUG #ifdef DEBUG
printf("\nread failed\n"); printf("\nread failed\n");
#endif #endif
free(buf); free(buf);
return (NULL); return (NULL);
} }
return (buf); return (buf);
} }
▲ Show 20 Lines • Show All 51 Lines • Show Last 20 Lines
View Options

head/sys/dev/md/md.c

Show First 20 Lines • Show All 112 Lines • ▼ Show 20 Lines
/* /*
* Read the specified part of a file to kernel space. Unlike regular * Read the specified part of a file to kernel space. Unlike regular
* pread, the file pointer is advanced to the end of the read data, * pread, the file pointer is advanced to the end of the read data,
* and it just returns 0 if successful. * and it just returns 0 if successful.
*/ */
int int
kern_pread(int fd, vm_offset_t dest, size_t len, off_t off) kern_pread(int fd, vm_offset_t dest, size_t len, off_t off)
{ {
ssize_t nread;
if (lseek(fd, off, SEEK_SET) == -1) { if (lseek(fd, off, SEEK_SET) == -1) {
#ifdef DEBUG #ifdef DEBUG
printf("\nlseek failed\n"); printf("\nlseek failed\n");
#endif #endif
return (-1); return (-1);
} }
nread = archsw.arch_readin(fd, dest, len); if ((size_t)archsw.arch_readin(fd, dest, len) != len) {
if (nread != len) {
#ifdef DEBUG #ifdef DEBUG
printf("\nreadin failed\n"); printf("\nreadin failed\n");
#endif #endif
return (-1); return (-1);
} }
return (0); return (0);
} }
/* /*
* Read the specified part of a file to a malloced buffer. The file * Read the specified part of a file to a malloced buffer. The file
* pointer is advanced to the end of the read data. * pointer is advanced to the end of the read data.
*/ */
void * void *
alloc_pread(int fd, off_t off, size_t len) alloc_pread(int fd, off_t off, size_t len)
{ {
void *buf; void *buf;
ssize_t nread;
buf = malloc(len); buf = malloc(len);
if (buf == NULL) { if (buf == NULL) {
#ifdef DEBUG #ifdef DEBUG
printf("\nmalloc(%d) failed\n", (int)len); printf("\nmalloc(%d) failed\n", (int)len);
#endif #endif
return (NULL); return (NULL);
} }
if (lseek(fd, off, SEEK_SET) == -1) { if (lseek(fd, off, SEEK_SET) == -1) {
#ifdef DEBUG #ifdef DEBUG
printf("\nlseek failed\n"); printf("\nlseek failed\n");
#endif #endif
free(buf); free(buf);
return (NULL); return (NULL);
} }
nread = read(fd, buf, len); if ((size_t)read(fd, buf, len) != len) {
if (nread != len) {
#ifdef DEBUG #ifdef DEBUG
printf("\nread failed\n"); printf("\nread failed\n");
#endif #endif
free(buf); free(buf);
return (NULL); return (NULL);
} }
return (buf); return (buf);
} }
▲ Show 20 Lines • Show All 51 Lines • Show Last 20 Lines
View Options

head/sys/fs/tmpfs/tmpfs_subr.c

Show First 20 Lines • Show All 112 Lines • ▼ Show 20 Lines
/* /*
* Read the specified part of a file to kernel space. Unlike regular * Read the specified part of a file to kernel space. Unlike regular
* pread, the file pointer is advanced to the end of the read data, * pread, the file pointer is advanced to the end of the read data,
* and it just returns 0 if successful. * and it just returns 0 if successful.
*/ */
int int
kern_pread(int fd, vm_offset_t dest, size_t len, off_t off) kern_pread(int fd, vm_offset_t dest, size_t len, off_t off)
{ {
ssize_t nread;
if (lseek(fd, off, SEEK_SET) == -1) { if (lseek(fd, off, SEEK_SET) == -1) {
#ifdef DEBUG #ifdef DEBUG
printf("\nlseek failed\n"); printf("\nlseek failed\n");
#endif #endif
return (-1); return (-1);
} }
nread = archsw.arch_readin(fd, dest, len); if ((size_t)archsw.arch_readin(fd, dest, len) != len) {
if (nread != len) {
#ifdef DEBUG #ifdef DEBUG
printf("\nreadin failed\n"); printf("\nreadin failed\n");
#endif #endif
return (-1); return (-1);
} }
return (0); return (0);
} }
/* /*
* Read the specified part of a file to a malloced buffer. The file * Read the specified part of a file to a malloced buffer. The file
* pointer is advanced to the end of the read data. * pointer is advanced to the end of the read data.
*/ */
void * void *
alloc_pread(int fd, off_t off, size_t len) alloc_pread(int fd, off_t off, size_t len)
{ {
void *buf; void *buf;
ssize_t nread;
buf = malloc(len); buf = malloc(len);
if (buf == NULL) { if (buf == NULL) {
#ifdef DEBUG #ifdef DEBUG
printf("\nmalloc(%d) failed\n", (int)len); printf("\nmalloc(%d) failed\n", (int)len);
#endif #endif
return (NULL); return (NULL);
} }
if (lseek(fd, off, SEEK_SET) == -1) { if (lseek(fd, off, SEEK_SET) == -1) {
#ifdef DEBUG #ifdef DEBUG
printf("\nlseek failed\n"); printf("\nlseek failed\n");
#endif #endif
free(buf); free(buf);
return (NULL); return (NULL);
} }
nread = read(fd, buf, len); if ((size_t)read(fd, buf, len) != len) {
if (nread != len) {
#ifdef DEBUG #ifdef DEBUG
printf("\nread failed\n"); printf("\nread failed\n");
#endif #endif
free(buf); free(buf);
return (NULL); return (NULL);
} }
return (buf); return (buf);
} }
▲ Show 20 Lines • Show All 51 Lines • Show Last 20 Lines
View Options

head/sys/kern/uipc_shm.c

Show First 20 Lines • Show All 112 Lines • ▼ Show 20 Lines
/* /*
* Read the specified part of a file to kernel space. Unlike regular * Read the specified part of a file to kernel space. Unlike regular
* pread, the file pointer is advanced to the end of the read data, * pread, the file pointer is advanced to the end of the read data,
* and it just returns 0 if successful. * and it just returns 0 if successful.
*/ */
int int
kern_pread(int fd, vm_offset_t dest, size_t len, off_t off) kern_pread(int fd, vm_offset_t dest, size_t len, off_t off)
{ {
ssize_t nread;
if (lseek(fd, off, SEEK_SET) == -1) { if (lseek(fd, off, SEEK_SET) == -1) {
#ifdef DEBUG #ifdef DEBUG
printf("\nlseek failed\n"); printf("\nlseek failed\n");
#endif #endif
return (-1); return (-1);
} }
nread = archsw.arch_readin(fd, dest, len); if ((size_t)archsw.arch_readin(fd, dest, len) != len) {
if (nread != len) {
#ifdef DEBUG #ifdef DEBUG
printf("\nreadin failed\n"); printf("\nreadin failed\n");
#endif #endif
return (-1); return (-1);
} }
return (0); return (0);
} }
/* /*
* Read the specified part of a file to a malloced buffer. The file * Read the specified part of a file to a malloced buffer. The file
* pointer is advanced to the end of the read data. * pointer is advanced to the end of the read data.
*/ */
void * void *
alloc_pread(int fd, off_t off, size_t len) alloc_pread(int fd, off_t off, size_t len)
{ {
void *buf; void *buf;
ssize_t nread;
buf = malloc(len); buf = malloc(len);
if (buf == NULL) { if (buf == NULL) {
#ifdef DEBUG #ifdef DEBUG
printf("\nmalloc(%d) failed\n", (int)len); printf("\nmalloc(%d) failed\n", (int)len);
#endif #endif
return (NULL); return (NULL);
} }
if (lseek(fd, off, SEEK_SET) == -1) { if (lseek(fd, off, SEEK_SET) == -1) {
#ifdef DEBUG #ifdef DEBUG
printf("\nlseek failed\n"); printf("\nlseek failed\n");
#endif #endif
free(buf); free(buf);
return (NULL); return (NULL);
} }
nread = read(fd, buf, len); if ((size_t)read(fd, buf, len) != len) {
if (nread != len) {
#ifdef DEBUG #ifdef DEBUG
printf("\nread failed\n"); printf("\nread failed\n");
#endif #endif
free(buf); free(buf);
return (NULL); return (NULL);
} }
return (buf); return (buf);
} }
▲ Show 20 Lines • Show All 51 Lines • Show Last 20 Lines
View Options

head/sys/vm/swap_pager.c

Loading...
View Options

head/sys/vm/vm_fault.c

Loading...
View Options

head/sys/vm/vm_object.c

Loading...
View Options

head/sys/vm/vm_page.h

Loading...
View Options

head/sys/vm/vm_page.c

Loading...
View Options

head/sys/vm/vm_pageout.c

Loading...
View Options

head/sys/vm/vm_swapout.c

Loading...