Page MenuHomeFreeBSD

Fix a page leak in the md(4) swap I/O path.
ClosedPublic

Authored by markj on Jan 3 2020, 5:41 PM.

Details

Summary

In a last-minute change to D22885 I removed the vm_page_activate() call.
But this is of course needed to ensure that the pages end up in the page
queues in the first place.

Restore the pre-r356157 logic. Now, without the page lock, the
vm_page_active() check is racy, but this race is harmless.

Reported and tested by: pho

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markj created this revision.Jan 3 2020, 5:41 PM
kib accepted this revision.Jan 3 2020, 5:53 PM
This revision is now accepted and ready to land.Jan 3 2020, 5:53 PM
alc accepted this revision.Jan 3 2020, 6:05 PM
This revision was automatically updated to reflect the committed changes.