Remove page locking for queue operations.
ClosedPublic
Actions

Authored by markj on Dec 19 2019, 11:17 PM.

Details

Reviewers

alc
jeff
kib
dougm

Commits

rS356157: Remove page locking for queue operations.

Summary

With the previous reviews, the page lock is no longer required in order
to perform queue operations on a page. It is also no longer needed in
the page queue scans.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Dec 19 2019, 11:17 PM

Herald added a subscriber: delphij. · View Herald TranscriptDec 19 2019, 11:17 PM

Harbormaster completed remote builds in B28245: Diff 65832.Dec 19 2019, 11:17 PM

markj added reviewers: alc, jeff, kib, dougm.Dec 19 2019, 11:20 PM

This is excellent. What is left of vm_page_lock() after this?

sys/dev/md/md.c
1148 ↗	(On Diff #65832)	Does the activate not imply reference? Are both necessary?

jeff accepted this revision.Dec 20 2019, 11:14 PM

This revision is now accepted and ready to land.Dec 20 2019, 11:14 PM

Closed by commit rS356157: Remove page locking for queue operations. (authored by markj). · Explain WhyDec 28 2019, 7:04 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS356157: Remove page locking for queue operations..

Herald added a subscriber: imp. · View Herald TranscriptDec 28 2019, 7:04 PM

markj mentioned this in D23024: Fix a page leak in the md(4) swap I/O path..Jan 3 2020, 5:41 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

cddl/

contrib/

opensolaris/

uts/

common/

fs/

zfs/

dmu.c

4 lines

zfs_vnops.c

2 lines

dev/

md/

md.c

7 lines

fs/

tmpfs/

tmpfs_subr.c

2 lines

kern/

uipc_shm.c

2 lines

vm/

9 lines

30 lines

7 lines

8 lines

13 lines

177 lines

2 lines

Diff 66067

View Options

head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu.c

View Options

head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c

View Options

head/sys/dev/md/md.c

View Options

head/sys/fs/tmpfs/tmpfs_subr.c

View Options

head/sys/kern/uipc_shm.c

View Options

head/sys/vm/swap_pager.c

View Options

head/sys/vm/vm_fault.c

View Options

head/sys/vm/vm_object.c

View Options

head/sys/vm/vm_page.h

View Options

head/sys/vm/vm_page.c

View Options

head/sys/vm/vm_pageout.c

View Options

Remove page locking for queue operations.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 66067

head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu.c

head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c

head/sys/dev/md/md.c

head/sys/fs/tmpfs/tmpfs_subr.c

head/sys/kern/uipc_shm.c

head/sys/vm/swap_pager.c

head/sys/vm/vm_fault.c

head/sys/vm/vm_object.c

head/sys/vm/vm_page.h

head/sys/vm/vm_page.c

head/sys/vm/vm_pageout.c

head/sys/vm/vm_swapout.c

Remove page locking for queue operations.
ClosedPublic
Actions

Revision Contents
Changeset List