Include the tool name for toolchain variables when using CROSS_TOOLCHAIN.
ClosedPublic
Actions

Authored by jhb on Nov 28 2019, 4:55 PM.

Details

Reviewers

Group Reviewers

portmgr
O5: Ports Framework

Commits

rP520455: Include the tool name for toolchain variables when using CROSS_TOOLCHAIN.

Summary

Previously variables such as AS, LD, etc. were only set to the path
but not the tool itself due to a typo.

Test Plan

cross-building base/gcc after updating it to work with freebsd-gcc6 fails since base/gcc now uses these variables to set the corresponding <foo>_FOR_TARGET variables

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Nov 28 2019, 4:55 PM

Owners added a reviewer: O5: Ports Framework.Nov 28 2019, 4:55 PM

Herald added 1 blocking reviewer(s): portmgr. · View Herald TranscriptNov 28 2019, 4:55 PM

Herald added a subscriber: mat. · View Herald Transcript

Harbormaster completed remote builds in B27835: Diff 65009.Nov 28 2019, 4:56 PM

jhb added a child revision: D22594: Update base/gcc to work with devel/freebsd-gcc6..Nov 28 2019, 5:04 PM

lwhsu added a subscriber: lwhsu.Dec 2 2019, 8:25 AM

Ping. This is only relevant when CROSS_TOOLCHAIN is set, so should be low risk. It is a dependency of D22594.

Ping @bapt

bapt accepted this revision.Dec 19 2019, 8:19 AM

This revision is now accepted and ready to land.Dec 19 2019, 8:19 AM

Closed by commit rP520455: Include the tool name for toolchain variables when using CROSS_TOOLCHAIN. (authored by jhb). · Explain WhyDec 20 2019, 1:14 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rP520455: Include the tool name for toolchain variables when using CROSS_TOOLCHAIN..

Revision Contents
Changeset List

Path

Size

Packages

head/

Mk/

bsd.port.mk

2 lines

O5: Ports Framework

Diff 65837

View Options

Include the tool name for toolchain variables when using CROSS_TOOLCHAIN.ClosedPublicActions