Page MenuHomeFreeBSD

Use ARCH instead of MACHINE to check for mips.
Needs ReviewPublic

Authored by jhb on Thu, Nov 28, 4:53 PM.

Details

Reviewers
jbeich
Group Reviewers
portmgr
O5: Ports Framework(Owns No Changed Paths)
Summary

Cross-building ports via CROSS_TOOLCHAIN and CROSS_SYSROOT only set
ARCH to the target arch. MACHINE still references the host. This
unbreaks cross-building ports for mips.

Test Plan
  • try to cross-build base/gcc and have it fail due to SSP flags in CFLAGS

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 27834
Build 26012: arc lint + arc unit

Event Timeline

jhb created this revision.Thu, Nov 28, 4:53 PM
Herald added a subscriber: mat. · View Herald Transcript
lwhsu added a subscriber: lwhsu.Mon, Dec 2, 8:26 AM
jhb added a comment.Wed, Dec 11, 10:15 PM

Ping, this breaks using CROSS_TOOLCHAIN and CROSS_SYSROOT with mips.

jbeich accepted this revision.EditedWed, Dec 11, 11:03 PM

Looks OK:

  • ${ARCH} is defined in <bsd.port.options.mk> but Mk/bsd.ssp.mk is processed in <bsd.port.post.mk>
  • logic didn't change because mips64 was part of mips set, which I originally cargo-culted from <bsd.sys.mk> (after minor testing)

Sorry, I don't have time to reproduce your issue.

Mk/bsd.ssp.mk
7

! ${FOO:Mtest} is more common in ports/ than ${FOO:Mtest} == "".