Page MenuHomeFreeBSD

lagg: Try to clean up the rr_limit option.
ClosedPublic

Authored by markj on Dec 17 2019, 9:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 15, 2:01 AM
Unknown Object (File)
May 7 2026, 5:22 AM
Unknown Object (File)
May 6 2026, 2:36 PM
Unknown Object (File)
May 6 2026, 11:33 AM
Unknown Object (File)
Mar 30 2026, 3:27 PM
Unknown Object (File)
Mar 29 2026, 11:29 PM
Unknown Object (File)
Mar 27 2026, 6:48 AM
Unknown Object (File)
Mar 26 2026, 10:15 PM
Subscribers

Details

Summary
  • Don't allow an unprivileged user to set the stride.
  • Only set the stride under the softc lock.
  • Rename the internal fields to accurately reflect their use. I don't understand where the "bucket" terminology comes from. Keep ro_bkt to avoid changing the user API.
  • Simplify the implementation. The port index is just sc_seq / stride.
  • Document rr_limit in ifconfig.8.

I don't like the ifconfig option name of "rr_limit" as it doesn't really
express what the option means. I could rename that too and keep the old
name aliased for compatibility.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28202
Build 26327: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Dec 22 2019, 9:57 PM
This revision was automatically updated to reflect the committed changes.
head/sys/net/if_lagg.c
2058 ↗(On Diff #65920)

Are we sure sc_stride won't change between the test and the division?