Add compat.linux.emul_path
ClosedPublic
Actions

Authored by trasz on Nov 27 2019, 7:05 PM.

Details

Reviewers

manu
emaste

Group Reviewers

manpages
Linux Emulation

Commits

rS355818: Add compat.linux.emul_path, so it can be set to something other

Summary

Add compat.linux.emul_path, so it can be set to something other
than "/compat/linux". Useful when you have several compat directories
with different Linux versions.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28176
Build 26307: arc lint + arc unit

Event Timeline

trasz created this revision.Nov 27 2019, 7:05 PM

Herald added a reviewer: manu. · View Herald TranscriptNov 27 2019, 7:05 PM

Herald added a reviewer: manpages. · View Herald Transcript

Herald added subscribers: emaste, andrew, imp. · View Herald Transcript

Harbormaster completed remote builds in B27810: Diff 64957.Nov 27 2019, 7:05 PM

trasz added a reviewer: Linux Emulation.Nov 27 2019, 7:05 PM

OK from manpages.

lwhsu added a subscriber: lwhsu.Nov 27 2019, 7:50 PM

lwhsu added inline comments.

share/man/man4/linux.4
27	Don't forget to update the date.

Useful when you have several compat directories with different Linux versions.

So what's the difference with traditional approach of making /compat/linux a symlink to desired implementation?

In D22574#493843, @danfe wrote:

Useful when you have several compat directories with different Linux versions.

So what's the difference with traditional approach of making /compat/linux a symlink to desired implementation?

It doesn’t clash with linux_base-c7, for one. Besides it removes code (well, string) duplication.

trasz added a reviewer: emaste.Dec 14 2019, 11:37 AM

Fix build on aarch64.

Harbormaster completed remote builds in B28176: Diff 65707.Dec 16 2019, 1:53 PM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 16 2019, 8:07 PM

Closed by commit rS355818: Add compat.linux.emul_path, so it can be set to something other (authored by trasz). · Explain Why

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rS355818: Add compat.linux.emul_path, so it can be set to something other.