Page MenuHomeFreeBSD
Differential D22526

[PowerPC] Fix floating point environment manipulation
ClosedPublic
Actions

Authored by bdragon on Nov 24 2019, 12:56 AM.
Tags
Referenced Files
F162327064: D22526.id65518.diff
Sun, Jul 12, 2:27 AM
Unknown Object (File)
Thu, Jul 9, 3:30 AM
Unknown Object (File)
Wed, Jul 8, 8:41 PM
Unknown Object (File)
Wed, Jul 8, 11:13 AM
Unknown Object (File)
Fri, Jul 3, 2:50 PM
Unknown Object (File)
Thu, Jul 2, 3:51 PM
Unknown Object (File)
Wed, Jul 1, 5:26 AM
Unknown Object (File)
Wed, Jun 24, 6:34 AM
View All Files
Subscribers
alfredo
andrew
emaste
imp
luporl

Details

Reviewers
jhibbits
Commits
rGd905133e26d0: [PowerPC] Fix SPE floating point environment manipulation
rS355656: [PowerPC] Fix SPE floating point environment manipulation
Summary
  • Fix endianness problems in functions accessing and manipulating the floating point environment via fenv.h. (jhibbits wrote the original bits)
  • Fix bugs regarding synchronization requirements after writing SPEFSCR.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bdragon created this revision.Nov 24 2019, 12:56 AM
Herald added a subscriber: imp. · View Herald TranscriptNov 24 2019, 12:56 AM
jhibbits added a comment.Nov 24 2019, 1:00 AM

You found the bugs with the kyua tests, did you retest post-changes?

lib/msun/powerpc/fenv.h
94–95 ↗(On Diff #64789)

I think these need line wrapped.

bdragon updated this revision to Diff 65517.Dec 12 2019, 12:31 AM

Linewrap fenv.h macros.

Herald added a reviewer: manu. · View Herald TranscriptDec 12 2019, 12:31 AM
Herald added subscribers: alfredo, luporl, emaste, andrew. · View Herald Transcript
bdragon added a comment.Dec 12 2019, 12:33 AM

ugh, think that was the wrong diff. Moment.

bdragon updated this revision to Diff 65518.Dec 12 2019, 12:35 AM

Actually upload the *correct* diff this time

bdragon removed a reviewer: manu.Dec 12 2019, 12:36 AM
bdragon marked an inline comment as done.
jhibbits accepted this revision.Dec 12 2019, 4:47 PM
This revision is now accepted and ready to land.Dec 12 2019, 4:47 PM
Closed by commit rS355656: [PowerPC] Fix SPE floating point environment manipulation (authored by bdragon). · Explain WhyDec 12 2019, 5:12 PM
This revision was automatically updated to reflect the committed changes.
bdragon added a commit: rS355656: [PowerPC] Fix SPE floating point environment manipulation.
bdragon added a commit: rGd905133e26d0: [PowerPC] Fix SPE floating point environment manipulation.Mar 8 2021, 7:08 PM

Revision Contents
Changeset List

PathSize
head/
lib/
libc/
powerpcspe/
gen/
2 lines
2 lines
msun/
powerpc/
57 lines
sys/
powerpc/
booke/
2 lines

Diff 65553

View Options

head/lib/libc/powerpcspe/gen/fpsetmask.c

Loading...
View Options

head/lib/libc/powerpcspe/gen/fpsetround.c

Loading...
View Options

head/lib/msun/powerpc/fenv.h

Loading...
View Options

head/sys/powerpc/booke/spe.c

Loading...