Page MenuHomeFreeBSD

lang/rust: add powerpc64 ELFv2 support
ClosedPublic

Authored by mikael on Jun 28 2019, 1:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 22, 11:06 PM
Unknown Object (File)
Fri, Mar 22, 11:06 PM
Unknown Object (File)
Fri, Mar 22, 11:06 PM
Unknown Object (File)
Fri, Mar 22, 11:06 PM
Unknown Object (File)
Fri, Mar 22, 11:06 PM
Unknown Object (File)
Fri, Mar 22, 11:06 PM
Unknown Object (File)
Fri, Mar 22, 11:06 PM
Unknown Object (File)
Sun, Mar 10, 9:06 AM

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 27391
Build 25638: arc lint + arc unit

Event Timeline

jbeich added inline comments.
lang/rust/Makefile
140

Did you mean > and not >=? If so 1300036 users may end up using Clang but not ELFv2.

145

None of rustc --print target-list currently have OS version. Did you check ports depending on lang/rust build fine?

lang/rust/Makefile
145

Nevermind. I didn't notice this target is for LLVM.

need to fix osversion, distinfo, Uses/cargo.mk

lang/rust/Makefile
140

yes, it should be >=

145

I tried devel/bingrep, it works fine.

mikael edited the summary of this revision. (Show Details)

I did a

svn mv patch-src_librustc__llvm_build.rs extra-patch-ppc64-gcc

but it doesn't translate well in the diff, what is the correct way to do it?

mikael retitled this revision from lang/rust: WIP add powerpc64 ELFv2 support to lang/rust: add powerpc64 ELFv2 support.
mikael edited the summary of this revision. (Show Details)
mikael edited reviewers, added: rust; removed: portmgr.
tobik requested changes to this revision.Oct 16 2019, 9:07 AM
tobik added a subscriber: tobik.
tobik added inline comments.
lang/rust/Makefile
66

Please just use -${PPC_ABI:tl} and revert the distinfo changes. The bootstrap tarball filenames are all lowercase. Let's keep it that way.

91

EXTRA_PATCHES+=

139–145

It sure feels like this (and extra-patch-ppc64-gcc) should be some cfg! or env! thing in Rust rather than us wrangling with conditional patches, but not sure how that would work exactly. It's fine for now I guess.

249–251

Best add PPC_ABI=ELFv1 here so that makesum can still work as it should on every arch.

260

Replace BOOTSTRAPS_SUFFIX with PPC_ABI=ELFv2.

261–262

Revert these too.

This revision now requires changes to proceed.Oct 16 2019, 9:07 AM
This revision is now accepted and ready to land.Nov 7 2019, 6:19 PM