Page MenuHomeFreeBSD
Differential D20792

lang/rust: add powerpc64 ELFv2 support
ClosedPublic
Actions

Authored by mikael on Jun 28 2019, 1:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 8:51 PM
Unknown Object (File)
Sat, Apr 20, 8:51 PM
Unknown Object (File)
Sat, Apr 20, 8:51 PM
Unknown Object (File)
Sat, Apr 20, 3:30 PM
Unknown Object (File)
Mar 22 2024, 11:06 PM
Unknown Object (File)
Mar 22 2024, 11:06 PM
Unknown Object (File)
Mar 22 2024, 11:06 PM
Unknown Object (File)
Mar 22 2024, 11:06 PM
View All 68 Files
Subscribers
alfredo
jbeich
linimon
mat
tobik
Contributor Reviewers (ports)

Details

Reviewers
tobik
Group Reviewers
rust
Commits
rP517954: lang/rust: Add missing bits for powerpc64 ELFv2 support via PPC_ABI
Summary

https://lists.freebsd.org/pipermail/freebsd-ppc/2019-June/010632.html
https://wiki.freebsd.org/powerpc/llvm-elfv2

http://mikael.urankar.free.fr/FreeBSD/rust/1.38.0/cargo-0.39.0-powerpc64-unknown-freebsd-ELFv2.tar.gz
http://mikael.urankar.free.fr/FreeBSD/rust/1.38.0/rust-std-1.38.0-powerpc64-unknown-freebsd-ELFv2.tar.gz
http://mikael.urankar.free.fr/FreeBSD/rust/1.38.0/rustc-1.38.0-powerpc64-unknown-freebsd-ELFv2.tar.gz

needs https://reviews.freebsd.org/D22039

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

mikael created this revision.Jun 28 2019, 1:59 PM
Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptJun 28 2019, 1:59 PM
linimon added a subscriber: linimon.Jun 28 2019, 2:10 PM
jbeich added a subscriber: jbeich.Jun 28 2019, 2:59 PM
jbeich added inline comments.
lang/rust/Makefile
139

Did you mean > and not >=? If so 1300036 users may end up using Clang but not ELFv2.

144

None of rustc --print target-list currently have OS version. Did you check ports depending on lang/rust build fine?

jbeich added inline comments.Jun 28 2019, 3:01 PM
lang/rust/Makefile
144

Nevermind. I didn't notice this target is for LLVM.

mikael added a comment.Jun 28 2019, 4:05 PM

need to fix osversion, distinfo, Uses/cargo.mk

lang/rust/Makefile
139

yes, it should be >=

144

I tried devel/bingrep, it works fine.

alfredo added a subscriber: alfredo.Jun 28 2019, 5:26 PM
mikael updated this revision to Diff 59187.Jun 29 2019, 9:11 AM
mikael edited the summary of this revision. (Show Details)

I did a

svn mv patch-src_librustc__llvm_build.rs extra-patch-ppc64-gcc

but it doesn't translate well in the diff, what is the correct way to do it?

Herald added a reviewer: portmgr. · View Herald TranscriptJun 29 2019, 9:11 AM
mikael updated this revision to Diff 63311.Oct 15 2019, 5:49 PM
mikael retitled this revision from lang/rust: WIP add powerpc64 ELFv2 support to lang/rust: add powerpc64 ELFv2 support.
mikael edited the summary of this revision. (Show Details)
mikael edited reviewers, added: rust; removed: portmgr.
tobik requested changes to this revision.Oct 16 2019, 9:07 AM
tobik added a subscriber: tobik.
tobik added inline comments.
lang/rust/Makefile
70

Please just use -${PPC_ABI:tl} and revert the distinfo changes. The bootstrap tarball filenames are all lowercase. Let's keep it that way.

91

EXTRA_PATCHES+=

138–144

It sure feels like this (and extra-patch-ppc64-gcc) should be some cfg! or env! thing in Rust rather than us wrangling with conditional patches, but not sure how that would work exactly. It's fine for now I guess.

256–258

Best add PPC_ABI=ELFv1 here so that makesum can still work as it should on every arch.

265

Replace BOOTSTRAPS_SUFFIX with PPC_ABI=ELFv2.

266–267

Revert these too.

This revision now requires changes to proceed.Oct 16 2019, 9:07 AM
mikael updated this revision to Diff 63349.Oct 16 2019, 11:06 AM

address comments

tobik mentioned this in D22240: lang/rust: Update to 1.39.0.Nov 5 2019, 5:23 AM
tobik mentioned this in rP516995: lang/rust: Update to 1.39.0.Nov 7 2019, 6:07 PM
tobik updated this revision to Diff 64047.Nov 7 2019, 6:10 PM
Harbormaster completed remote builds in B27391: Diff 64047.Nov 7 2019, 6:10 PM
tobik accepted this revision.Nov 7 2019, 6:19 PM
This revision is now accepted and ready to land.Nov 7 2019, 6:19 PM
Closed by commit rP517954: lang/rust: Add missing bits for powerpc64 ELFv2 support via PPC_ABI (authored by tobik). · Explain WhyNov 19 2019, 9:28 AM
This revision was automatically updated to reflect the committed changes.
tobik added a commit: rP517954: lang/rust: Add missing bits for powerpc64 ELFv2 support via PPC_ABI.

Revision Contents
Changeset List

Diff 63311

View Options

lang/rust/Makefile

Loading...
View Options

lang/rust/distinfo

Loading...
View Options

lang/rust/files/extra-patch-ppc64-gcc

Loading...
View Options

lang/rust/files/patch-llvm

Loading...
View Options

lang/rust/files/patch-src_bootstrap_native.rs

Loading...
View Options

lang/rust/files/patch-src_librustc__llvm_build.rs

Loading...