Differential D21975

RISC-V: Call devmap_bootstrap()
ClosedPublic
Actions

Authored by nick on Oct 10 2019, 8:34 PM.

Details

Reviewers

philip
br
kp

Commits

rS353441: Call devmap_bootstrap in RISC-V machine dependent code to actually create

Summary

RISC-V support has been added to devmap but devmap_bootstrap never gets
called therefore never actually creating the mapped device regions.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

nick created this revision.Oct 10 2019, 8:34 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 10 2019, 8:34 PM

Other than the minor style(9) violation, this looks good to me!

sys/riscv/riscv/machdep.c
69	Please try to keep includes in alphabetical order. See style(9).

This revision now requires changes to proceed.Oct 10 2019, 8:38 PM

I don't object to the change, but do we actually create any static mappings currently? This is a no-op otherwise.

In D21975#480074, @mhorne wrote:

I don't object to the change, but do we actually create any static mappings currently? This is a no-op otherwise.

FreeBSD proper doesn't on RISC-V, but downstreams do.. (or want to).

nick updated this revision to Diff 63136.Oct 10 2019, 9:19 PM

This comment was removed by nick.

Fix the header order (alphabetical)

philip accepted this revision.Oct 10 2019, 9:22 PM

This revision is now accepted and ready to land.Oct 10 2019, 9:22 PM

In D21975#480078, @philip wrote:

In D21975#480074, @mhorne wrote:

I don't object to the change, but do we actually create any static mappings currently? This is a no-op otherwise.

FreeBSD proper doesn't on RISC-V, but downstreams do.. (or want to).