Page MenuHomeFreeBSD
Differential D21975

RISC-V: Call devmap_bootstrap()
ClosedPublic
Actions

Authored by nick on Oct 10 2019, 8:34 PM.
Tags
None
Referenced Files
F136500493: D21975.id63137.diff
Tue, Nov 18, 1:56 AM
Unknown Object (File)
Thu, Nov 13, 2:50 AM
Unknown Object (File)
Mon, Nov 10, 7:54 PM
Unknown Object (File)
Thu, Nov 6, 12:29 AM
Unknown Object (File)
Wed, Nov 5, 12:16 PM
Unknown Object (File)
Fri, Oct 31, 12:40 AM
Unknown Object (File)
Thu, Oct 30, 7:45 PM
Unknown Object (File)
Thu, Oct 30, 7:45 PM
View All Files
Subscribers
imp
mhorne

Details

Reviewers
philip
br
kp
Commits
rS353441: Call devmap_bootstrap in RISC-V machine dependent code to actually create
Summary

RISC-V support has been added to devmap but devmap_bootstrap never gets
called therefore never actually creating the mapped device regions.

Sponsored by: Axiado

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nick created this revision.Oct 10 2019, 8:34 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 10 2019, 8:34 PM
philip requested changes to this revision.Oct 10 2019, 8:38 PM

Other than the minor style(9) violation, this looks good to me!

sys/riscv/riscv/machdep.c
68 ↗(On Diff #63135)

Please try to keep includes in alphabetical order. See style(9).

This revision now requires changes to proceed.Oct 10 2019, 8:38 PM
mhorne added a subscriber: mhorne.Oct 10 2019, 9:00 PM

I don't object to the change, but do we actually create any static mappings currently? This is a no-op otherwise.

philip added a comment.Oct 10 2019, 9:04 PM
In D21975#480074, @mhorne wrote:

I don't object to the change, but do we actually create any static mappings currently? This is a no-op otherwise.

FreeBSD proper doesn't on RISC-V, but downstreams do.. (or want to).

nick updated this revision to Diff 63136.Oct 10 2019, 9:19 PM
This comment was removed by nick.
nick updated this revision to Diff 63137.Oct 10 2019, 9:21 PM

Fix the header order (alphabetical)

philip accepted this revision.Oct 10 2019, 9:22 PM
This revision is now accepted and ready to land.Oct 10 2019, 9:22 PM
mhorne added a comment.Oct 11 2019, 3:05 AM
In D21975#480078, @philip wrote:
In D21975#480074, @mhorne wrote:

I don't object to the change, but do we actually create any static mappings currently? This is a no-op otherwise.

FreeBSD proper doesn't on RISC-V, but downstreams do.. (or want to).

Thanks, good to know!

br accepted this revision.Oct 11 2019, 3:15 PM
Closed by commit rS353441: Call devmap_bootstrap in RISC-V machine dependent code to actually create (authored by philip). · Explain WhyOct 11 2019, 4:28 PM
This revision was automatically updated to reflect the committed changes.
philip added a commit: rS353441: Call devmap_bootstrap in RISC-V machine dependent code to actually create.

Revision Contents
Changeset List

PathSize
head/
sys/
riscv/
riscv/
4 lines

Diff 63154

View Options

head/sys/riscv/riscv/machdep.c

Loading...