Page MenuHomeFreeBSD
Differential D21831

Add IFLIB_SINGLE_IRQ_RX_ONLY.
ClosedPublic
Actions

Authored by markj on Sep 28 2019, 5:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 28, 10:36 PM
Unknown Object (File)
Tue, May 26, 9:28 AM
Unknown Object (File)
Mon, May 25, 8:47 PM
Unknown Object (File)
Sun, May 24, 6:53 PM
Unknown Object (File)
Sat, May 23, 8:18 PM
Unknown Object (File)
May 3 2026, 7:16 PM
Unknown Object (File)
Apr 30 2026, 12:51 AM
Unknown Object (File)
Apr 29 2026, 8:02 AM
View All Files
Subscribers
ae
imp
otis

Details

Reviewers
shurd
marius
pkelsey
gallatin
Group Reviewers
iflib
Commits
rS352906: Add IFLIB_SINGLE_IRQ_RX_ONLY.
Summary

vmxnet3 assumes that tx state is not accessed from the interrupt
handler. r347221 broke that assumption. Add a legacy mode flag to
configure iflib to not do tx processing from the interrupt handler.

Submitted by: marius

Test Plan

See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239118

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26752
Build 25104: arc lint + arc unit

Event Timeline

markj created this revision.Sep 28 2019, 5:15 PM
Herald added a reviewer: shurd. · View Herald TranscriptSep 28 2019, 5:15 PM
Herald added a reviewer: iflib. · View Herald Transcript
Herald added a subscriber: ae. · View Herald Transcript
Harbormaster completed remote builds in B26752: Diff 62688.Sep 28 2019, 5:15 PM
markj edited the test plan for this revision. (Show Details)Sep 28 2019, 5:16 PM
markj added reviewers: marius, pkelsey.
otis added a subscriber: otis.Sep 28 2019, 10:30 PM

Functionally it's the same code that I was "MFCd" into my working tree.

gallatin accepted this revision as: gallatin.Sep 29 2019, 1:41 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 30 2019, 3:59 PM
Closed by commit rS352906: Add IFLIB_SINGLE_IRQ_RX_ONLY. (authored by markj). · Explain Why
This revision was automatically updated to reflect the committed changes.
markj added a commit: rS352906: Add IFLIB_SINGLE_IRQ_RX_ONLY..
Herald added a subscriber: imp. · View Herald TranscriptSep 30 2019, 3:59 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
vmware/
vmxnet3/
2 lines
net/
5 lines
9 lines

Diff 62688

View Options

sys/dev/vmware/vmxnet3/if_vmx.c

Loading...
View Options

sys/net/iflib.h

Loading...
View Options

sys/net/iflib.c

Loading...