Page MenuHomeFreeBSD
Differential D21824

Fix pmap_page_is_mapped() for arm64 and riscv.
ClosedPublic
Actions

Authored by markj on Sep 27 2019, 4:37 PM.
Tags
None
Referenced Files
F171432123: D21824.diff
Fri, Sep 11, 2:51 AM
F171417494: D21824.id62656.diff
Fri, Sep 11, 12:46 AM
F171406342: D21824.id62653.diff
Thu, Sep 10, 11:03 PM
F171339289: D21824.id62670.diff
Thu, Sep 10, 1:11 PM
F171317755: D21824.diff
Thu, Sep 10, 9:11 AM
Unknown Object (File)
Wed, Sep 9, 10:46 PM
Unknown Object (File)
Mon, Sep 7, 4:42 PM
Unknown Object (File)
Thu, Aug 27, 9:56 PM
View All Files
Subscribers
andrew
emaste
imp

Details

Reviewers
manu
alc
kib
andrew
Commits
rS352826: Implement pmap_page_is_mapped() correctly on arm64 and riscv.
Summary

To be correct, this function needs to look at 2MB mappings as well. I
just copied the implementation from amd64.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26738
Build 25091: arc lint + arc unit

Event Timeline

markj created this revision.Sep 27 2019, 4:37 PM
Herald added a reviewer: manu. · View Herald TranscriptSep 27 2019, 4:37 PM
Herald added subscribers: emaste, andrew. · View Herald Transcript
Harbormaster completed remote builds in B26738: Diff 62653.Sep 27 2019, 4:37 PM
markj added reviewers: alc, kib, andrew.Sep 27 2019, 4:37 PM
alc accepted this revision.Sep 27 2019, 4:57 PM
alc added inline comments.
sys/arm64/include/pmap.h
170–171

You need to replace this by the function declaration from amd64:

boolean_t pmap_page_is_mapped(vm_page_t m);

This revision is now accepted and ready to land.Sep 27 2019, 4:57 PM
markj updated this revision to Diff 62656.Sep 27 2019, 5:24 PM

Add missing prototypes.

This revision now requires review to proceed.Sep 27 2019, 5:24 PM
Harbormaster completed remote builds in B26739: Diff 62656.Sep 27 2019, 5:24 PM
alc accepted this revision.Sep 27 2019, 9:24 PM

Here is a take-it-or-leave comment: Consider conversion from "boolean_t" to "bool".

This revision is now accepted and ready to land.Sep 27 2019, 9:24 PM
Closed by commit rS352826: Implement pmap_page_is_mapped() correctly on arm64 and riscv. (authored by markj). · Explain WhySep 27 2019, 11:37 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rS352826: Implement pmap_page_is_mapped() correctly on arm64 and riscv..
Herald added a subscriber: imp. · View Herald TranscriptSep 27 2019, 11:37 PM

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
21 lines
include/
2 lines
riscv/
include/
2 lines
riscv/
21 lines

Diff 62653

View Options

sys/arm64/arm64/pmap.c

Loading...
View Options

sys/arm64/include/pmap.h

Loading...
View Options

sys/riscv/include/pmap.h

Loading...
View Options

sys/riscv/riscv/pmap.c

Loading...