Page MenuHomeFreeBSD

Fix pmap_page_is_mapped() for arm64 and riscv.
ClosedPublic

Authored by markj on Sep 27 2019, 4:37 PM.
Tags
None
Referenced Files
F106097387: D21824.diff
Wed, Dec 25, 8:50 AM
Unknown Object (File)
Sun, Dec 22, 3:10 PM
Unknown Object (File)
Mon, Dec 9, 1:43 PM
Unknown Object (File)
Fri, Nov 29, 11:18 AM
Unknown Object (File)
Sep 27 2024, 4:47 PM
Unknown Object (File)
Sep 21 2024, 9:10 PM
Unknown Object (File)
Sep 20 2024, 11:53 PM
Unknown Object (File)
Sep 19 2024, 4:41 AM
Subscribers

Details

Summary

To be correct, this function needs to look at 2MB mappings as well. I
just copied the implementation from amd64.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26738
Build 25091: arc lint + arc unit

Event Timeline

alc added inline comments.
sys/arm64/include/pmap.h
170–171

You need to replace this by the function declaration from amd64:

boolean_t pmap_page_is_mapped(vm_page_t m);

This revision is now accepted and ready to land.Sep 27 2019, 4:57 PM
This revision now requires review to proceed.Sep 27 2019, 5:24 PM

Here is a take-it-or-leave comment: Consider conversion from "boolean_t" to "bool".

This revision is now accepted and ready to land.Sep 27 2019, 9:24 PM