Differential D21492

Make linux_common depend on pty.
ClosedPublic
Actions

Authored by trasz on Sep 2 2019, 6:38 PM.

Tags

None

Referenced Files

	F153812511: D21492.id.diff
	Thu, Apr 23, 11:11 PM

	F153807804: D21492.id.diff
	Thu, Apr 23, 10:15 PM

	Unknown Object (File)
	Tue, Apr 21, 6:29 PM

	Unknown Object (File)
	Tue, Apr 21, 8:05 AM

	Unknown Object (File)
	Mon, Apr 20, 11:37 AM

	Unknown Object (File)
	Sun, Apr 19, 9:25 PM

	Unknown Object (File)
	Fri, Apr 17, 9:13 PM

	Unknown Object (File)
	Fri, Apr 17, 8:02 AM

Subscribers

Details

Reviewers

dchagin
emaste
brooks

Group Reviewers

Linux Emulation
manpages

Commits

rS354139: Document the fact that Linux binaries depend on pty(4).

Summary

Make linux_common depend on pty. This fixes Linux screen(1), tmux(1), and sshd(8).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26236
Build 24728: arc lint + arc unit

Event Timeline

trasz created this revision.Sep 2 2019, 6:38 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 2 2019, 6:38 PM

Harbormaster completed remote builds in B26236: Diff 61566.Sep 2 2019, 6:38 PM

trasz added reviewers: dchagin, emaste, Linux Emulation.Sep 2 2019, 6:39 PM

trasz edited the summary of this revision. (Show Details)Sep 2 2019, 6:45 PM

trasz edited the summary of this revision. (Show Details)

Update the man page.

Herald added a reviewer: manpages. · View Herald TranscriptSep 3 2019, 10:54 AM

Harbormaster completed remote builds in B26243: Diff 61575.Sep 3 2019, 10:54 AM

OK from manpages.

trasz added a reviewer: brooks.Sep 9 2019, 12:40 PM

Fine with me

This revision is now accepted and ready to land.Sep 9 2019, 1:20 PM

brooks added inline comments.Sep 9 2019, 1:27 PM

share/man/man4/pty.4
42 ↗	(On Diff #61575)	s/it got replaced with/it was replaced by/
44 ↗	(On Diff #61575)	I'd probably make the still used in linux bit it's own sentence (e.g. put a period after "its 4" and say something like "This traditional naming is still used in Linux."

Man page improvements from Brooks.

This revision now requires review to proceed.Sep 9 2019, 1:40 PM

Harbormaster completed remote builds in B26357: Diff 61838.Sep 9 2019, 1:40 PM

trasz marked 2 inline comments as done.Sep 9 2019, 1:40 PM

emaste accepted this revision.Sep 9 2019, 1:51 PM

This revision is now accepted and ready to land.Sep 9 2019, 1:51 PM

LGTM

(Tinderboxed.)

Closed by commit rS354139: Document the fact that Linux binaries depend on pty(4). (authored by trasz). · Explain WhyOct 28 2019, 9:22 PM

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rS354139: Document the fact that Linux binaries depend on pty(4)..

Revision Contents
Changeset List

Path

Size

sys/

compat/

linux/

1 line

dev/

pty/

1 line

Diff 61566

sys/compat/linux/linux_common.c

Loading...

sys/dev/pty/pty.c

Loading...