Page MenuHomeFreeBSD
Differential D21295

Rework r339635 to fix .depend.tables.h handling.
ClosedPublic
Actions

Authored by bdrewery on Aug 16 2019, 8:00 PM.
Tags
None
Referenced Files
F115151333: D21295.id60916.diff
Sun, Apr 20, 11:09 PM
Unknown Object (File)
Tue, Apr 15, 3:53 AM
Unknown Object (File)
Tue, Apr 15, 3:48 AM
Unknown Object (File)
Tue, Apr 15, 3:45 AM
Unknown Object (File)
Tue, Apr 15, 3:44 AM
Unknown Object (File)
Tue, Apr 15, 3:43 AM
Unknown Object (File)
Mar 21 2025, 8:45 AM
Unknown Object (File)
Mar 13 2025, 4:37 AM
View All 85 Files
Subscribers
imp

Details

Reviewers
emaste
lwhsu
jhb
asomers
Commits
rS351151: Rework r339635 to fix .depend.tables.h handling.
Summary

Avoid touching the tables.h file unless it has changed to avoid unneeded
rebuilds.

MFC after: 2 weeks
PR: 238828
Sponsored by: DellEMC

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bdrewery created this revision.Aug 16 2019, 8:00 PM
Harbormaster completed remote builds in B25924: Diff 60909.Aug 16 2019, 8:00 PM
bdrewery mentioned this in D21069: libsysdecode: automate tables.h dependency generation.Aug 16 2019, 8:00 PM
emaste added inline comments.Aug 16 2019, 8:15 PM
lib/libsysdecode/Makefile
127–128 ↗(On Diff #60909)

need to remove these explicit dependencies

emaste added inline comments.Aug 16 2019, 8:18 PM
lib/libsysdecode/Makefile
127–128 ↗(On Diff #60909)

and then incdir can go away also, expanded inline below.

emaste added inline comments.Aug 16 2019, 8:19 PM
lib/libsysdecode/mktables
177 ↗(On Diff #60909)

> probably?

emaste added a comment.Aug 16 2019, 8:45 PM

LGTM other than the minor comments inline

bdrewery updated this revision to Diff 60916.Aug 16 2019, 9:32 PM
bdrewery marked 3 inline comments as done.

Review findings

Harbormaster completed remote builds in B25927: Diff 60916.Aug 16 2019, 9:32 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 16 2019, 10:34 PM
Closed by commit rS351151: Rework r339635 to fix .depend.tables.h handling. (authored by bdrewery). · Explain Why
This revision was automatically updated to reflect the committed changes.
bdrewery added a commit: rS351151: Rework r339635 to fix .depend.tables.h handling..
Herald added a subscriber: imp. · View Herald TranscriptAug 16 2019, 10:34 PM

Revision Contents
Changeset List

PathSize
head/
lib/
libsysdecode/
9 lines
21 lines

Diff 60919

View Options

head/lib/libsysdecode/Makefile

Show First 20 Lines • Show All 186 Lines • ▼ Show 20 Lines case LINUX_SYS_linux_clock_nanosleep:
putchar(','); putchar(',');
ip++; ip++;
narg--; narg--;
print_mask_arg0(sysdecode_linux_clock_flags, *ip); print_mask_arg0(sysdecode_linux_clock_flags, *ip);
c = ','; c = ',';
ip++; ip++;
narg--; narg--;
break; break;
case LINUX_SYS_linux_clone:
putchar('(');
print_mask_arg(sysdecode_linux_clone_flags, *ip);
ip++;
narg--;
c = ',';
emasteUnsubmitted
Not Done
Inline Actions

FWIW most (but not all) existing cases seem to follow the pattern

		c = ',';
		ip++;
		narg--;

(i.e., setting 'c' first)

emaste: FWIW most (but not all) existing cases seem to follow the pattern ``` c = ','; ip++; narg…
break;
case LINUX_SYS_linux_kill: case LINUX_SYS_linux_kill:
case LINUX_SYS_linux_tkill: case LINUX_SYS_linux_tkill:
case LINUX_SYS_linux_rt_sigqueueinfo: case LINUX_SYS_linux_rt_sigqueueinfo:
print_number(ip, narg, c); print_number(ip, narg, c);
putchar(','); putchar(',');
print_linux_signal(*ip); print_linux_signal(*ip);
ip++; ip++;
narg--; narg--;
▲ Show 20 Lines • Show All 185 Lines • ▼ Show 20 Lines case LINUX32_SYS_linux_clock_nanosleep:
sysdecode_linux_clockid(stdout, *ip); sysdecode_linux_clockid(stdout, *ip);
putchar(','); putchar(',');
ip++; ip++;
narg--; narg--;
print_mask_arg0(sysdecode_linux_clock_flags, *ip); print_mask_arg0(sysdecode_linux_clock_flags, *ip);
c = ','; c = ',';
ip++; ip++;
narg--; narg--;
break;
case LINUX32_SYS_linux_clone:
putchar('(');
print_mask_arg(sysdecode_linux_clone_flags, *ip);
ip++;
narg--;
c = ',';
break; break;
case LINUX32_SYS_linux_kill: case LINUX32_SYS_linux_kill:
case LINUX32_SYS_linux_tkill: case LINUX32_SYS_linux_tkill:
case LINUX32_SYS_linux_rt_sigqueueinfo: case LINUX32_SYS_linux_rt_sigqueueinfo:
print_number(ip, narg, c); print_number(ip, narg, c);
putchar(','); putchar(',');
print_linux_signal(*ip); print_linux_signal(*ip);
ip++; ip++;
▲ Show 20 Lines • Show All 111 Lines • Show Last 20 Lines
View Options

head/lib/libsysdecode/mktables

Show First 20 Lines • Show All 186 Lines • ▼ Show 20 Lines case LINUX_SYS_linux_clock_nanosleep:
putchar(','); putchar(',');
ip++; ip++;
narg--; narg--;
print_mask_arg0(sysdecode_linux_clock_flags, *ip); print_mask_arg0(sysdecode_linux_clock_flags, *ip);
c = ','; c = ',';
ip++; ip++;
narg--; narg--;
break; break;
case LINUX_SYS_linux_clone:
putchar('(');
print_mask_arg(sysdecode_linux_clone_flags, *ip);
ip++;
narg--;
c = ',';
emasteUnsubmitted
Not Done
Inline Actions

FWIW most (but not all) existing cases seem to follow the pattern

		c = ',';
		ip++;
		narg--;

(i.e., setting 'c' first)

emaste: FWIW most (but not all) existing cases seem to follow the pattern ``` c = ','; ip++; narg…
break;
case LINUX_SYS_linux_kill: case LINUX_SYS_linux_kill:
case LINUX_SYS_linux_tkill: case LINUX_SYS_linux_tkill:
case LINUX_SYS_linux_rt_sigqueueinfo: case LINUX_SYS_linux_rt_sigqueueinfo:
print_number(ip, narg, c); print_number(ip, narg, c);
putchar(','); putchar(',');
print_linux_signal(*ip); print_linux_signal(*ip);
ip++; ip++;
narg--; narg--;
▲ Show 20 Lines • Show All 185 Lines • ▼ Show 20 Lines case LINUX32_SYS_linux_clock_nanosleep:
sysdecode_linux_clockid(stdout, *ip); sysdecode_linux_clockid(stdout, *ip);
putchar(','); putchar(',');
ip++; ip++;
narg--; narg--;
print_mask_arg0(sysdecode_linux_clock_flags, *ip); print_mask_arg0(sysdecode_linux_clock_flags, *ip);
c = ','; c = ',';
ip++; ip++;
narg--; narg--;
break;
case LINUX32_SYS_linux_clone:
putchar('(');
print_mask_arg(sysdecode_linux_clone_flags, *ip);
ip++;
narg--;
c = ',';
break; break;
case LINUX32_SYS_linux_kill: case LINUX32_SYS_linux_kill:
case LINUX32_SYS_linux_tkill: case LINUX32_SYS_linux_tkill:
case LINUX32_SYS_linux_rt_sigqueueinfo: case LINUX32_SYS_linux_rt_sigqueueinfo:
print_number(ip, narg, c); print_number(ip, narg, c);
putchar(','); putchar(',');
print_linux_signal(*ip); print_linux_signal(*ip);
ip++; ip++;
▲ Show 20 Lines • Show All 111 Lines • Show Last 20 Lines