Page MenuHomeFreeBSD

Rework r339635 to fix .depend.tables.h handling.
ClosedPublic

Authored by bdrewery on Aug 16 2019, 8:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 14 2024, 3:48 AM
Unknown Object (File)
Jan 5 2024, 12:18 PM
Unknown Object (File)
Jan 5 2024, 12:17 PM
Unknown Object (File)
Jan 5 2024, 12:17 PM
Unknown Object (File)
Jan 5 2024, 12:17 PM
Unknown Object (File)
Jan 5 2024, 12:05 PM
Unknown Object (File)
Dec 29 2023, 2:39 PM
Unknown Object (File)
Dec 23 2023, 8:25 PM
Subscribers

Details

Summary

Avoid touching the tables.h file unless it has changed to avoid unneeded
rebuilds.

MFC after: 2 weeks
PR: 238828
Sponsored by: DellEMC

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lib/libsysdecode/Makefile
127–128 ↗(On Diff #60909)

need to remove these explicit dependencies

lib/libsysdecode/Makefile
127–128 ↗(On Diff #60909)

and then incdir can go away also, expanded inline below.

lib/libsysdecode/mktables
177 ↗(On Diff #60909)

> probably?

LGTM other than the minor comments inline

bdrewery marked 3 inline comments as done.

Review findings

This revision was not accepted when it landed; it landed in state Needs Review.Aug 16 2019, 10:34 PM
This revision was automatically updated to reflect the committed changes.