Rework r339635 to fix .depend.tables.h handling.
ClosedPublic
Actions

Authored by bdrewery on Aug 16 2019, 8:00 PM.

Details

Reviewers

emaste
lwhsu
jhb
asomers

Commits

rS351151: Rework r339635 to fix .depend.tables.h handling.

Summary

Avoid touching the tables.h file unless it has changed to avoid unneeded
rebuilds.

MFC after: 2 weeks
PR: 238828
Sponsored by: DellEMC

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25927
Build 24491: arc lint + arc unit

Event Timeline

bdrewery created this revision.Aug 16 2019, 8:00 PM

Harbormaster completed remote builds in B25924: Diff 60909.Aug 16 2019, 8:00 PM

bdrewery mentioned this in D21069: libsysdecode: automate tables.h dependency generation.Aug 16 2019, 8:00 PM

emaste added inline comments.Aug 16 2019, 8:15 PM

lib/libsysdecode/Makefile
125–126	need to remove these explicit dependencies

emaste added inline comments.Aug 16 2019, 8:18 PM

lib/libsysdecode/Makefile
125–126	and then `incdir` can go away also, expanded inline below.

emaste added inline comments.Aug 16 2019, 8:19 PM

lib/libsysdecode/mktables
177	`>` probably?

LGTM other than the minor comments inline

Review findings

Harbormaster completed remote builds in B25927: Diff 60916.Aug 16 2019, 9:32 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 16 2019, 10:34 PM

Closed by commit rS351151: Rework r339635 to fix .depend.tables.h handling. (authored by bdrewery). · Explain Why

This revision was automatically updated to reflect the committed changes.

bdrewery added a commit: rS351151: Rework r339635 to fix .depend.tables.h handling..

Herald added a subscriber: imp. · View Herald TranscriptAug 16 2019, 10:34 PM

Revision Contents
Changeset List

Path

Size

lib/

libsysdecode/

Makefile

9 lines

mktables

21 lines

Diff 60916

View Options

lib/libsysdecode/Makefile