Differential D21240

net: add ETHER_IS_ZERO macro similar to ETHER_IS_BROADCAST
ClosedPublic
Actions

Authored by jacob.e.keller_intel.com on Aug 12 2019, 10:53 PM.

Details

Reviewers

erj

Group Reviewers

Intel Networking

Commits

rS354345: net: add ETHER_IS_ZERO macro similar to ETHER_IS_BROADCAST

Summary

Some places in network code may need to verify that an ethernet address
is not the 'zero' address. Provide a standard macro ETHER_IS_ZERO for
this purpose, similar to the ETHER_IS_BROADCAST macro already available.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25817
Build 24389: arc lint + arc unit

Event Timeline

jacob.e.keller_intel.com created this revision.Aug 12 2019, 10:53 PM

Herald added a subscriber: ae. · View Herald TranscriptAug 12 2019, 10:53 PM

Harbormaster completed remote builds in B25817: Diff 60699.Aug 12 2019, 10:53 PM

afedorov added a subscriber: afedorov.Aug 13 2019, 7:42 PM

afedorov added inline comments.

sys/net/ethernet.h
79	Is this correct? If one byte of mac address is equal zero than the whole expression equal 0x00.

jacob.e.keller_intel.com added inline comments.Aug 13 2019, 9:19 PM

sys/net/ethernet.h
79	Yea, this is incorrect, woops. Should be bitwise or.

Use bitwise OR instead of bitwise AND to correct implementation

Harbormaster completed remote builds in B25855: Diff 60761.Aug 13 2019, 9:21 PM

It’s seems I found another incorrect solution:

#include <stdio.h>

int main()
{

unsigned char a = (1 << 0) ||(1<<1)||(1 <<2)||(1<<3)||(1<<4)||(1<<5);
printf("momentum more : %d\n", a);

return 0;

}

In D21240#462131, @aleksandr.fedorov_itglobal.com wrote:
It’s seems I found another incorrect solution:

#include <stdio.h>

int main()
{
unsigned char a = (1 << 0) ||(1<<1)||(1 <<2)||(1<<3)||(1<<4)||(1<<5);
printf("momentum more : %d\n", a);

return 0;
}

This uses boolean ||, not bitwise |

bitwise OR should correctly combine all of the chunks of the MAC address, and if any are non-zero, the whole thing will be non-zero.

Ops, you’re right. Sorry for the noise.

lwhsu added a subscriber: scottl.Sep 14 2019, 1:37 PM

jacob.e.keller_intel.com added reviewers: Intel Networking, erj.Oct 23 2019, 6:35 PM

erj accepted this revision.Nov 4 2019, 9:50 PM

This revision is now accepted and ready to land.Nov 4 2019, 9:50 PM

I get a build error with this revision:

--- if_ure.o ---
/root/srcs/head/src/sys/dev/usb/net/if_ure.c:71:9: error: 'ETHER_IS_ZERO' macro redefined [-Werror,-Wmacro-redefined]
#define ETHER_IS_ZERO(addr) \
        ^
/root/srcs/head/src/sys/net/ethernet.h:77:9: note: previous definition is here
#define ETHER_IS_ZERO(addr) \
        ^
1 error generated.

This revision now requires changes to proceed.Nov 4 2019, 9:57 PM

Remove ETHER_IS_ZERO definitions from USB networking drivers.

Harbormaster completed remote builds in B27346: Diff 63943.Nov 4 2019, 11:29 PM