Page MenuHomeFreeBSD
Differential D20983

Sort & dedupe getopt flags for daemon
Needs ReviewPublic
Actions

Authored by darius-dons.net.au on Jul 18 2019, 4:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 11, 9:10 PM
Unknown Object (File)
Tue, Nov 25, 10:47 PM
Unknown Object (File)
Sat, Nov 22, 1:03 PM
Unknown Object (File)
Nov 1 2025, 9:22 PM
Unknown Object (File)
Oct 26 2025, 6:16 AM
Unknown Object (File)
Oct 24 2025, 10:09 PM
Unknown Object (File)
Oct 24 2025, 12:03 PM
Unknown Object (File)
Oct 22 2025, 3:39 PM
View All Files
Subscribers
bcr
cem
imp

Details

Reviewers
rpokala
pstef
Group Reviewers
manpages
Summary

As the title says.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

darius-dons.net.au created this revision.Jul 18 2019, 4:04 AM
Herald added a subscriber: imp. · View Herald TranscriptJul 18 2019, 4:04 AM
rpokala requested changes to this revision.Jul 18 2019, 5:18 AM

In addition to fixing the getopt() line, please upload a full diff, as described on the FreeBSD wiki: https://wiki.freebsd.org/action/show/Phabricator#Create_a_Revision_via_Web_Interface

daemon.getopt/daemon.c
104 ↗(On Diff #59863)

You lost three close-parens and an open-brace!

This revision now requires changes to proceed.Jul 18 2019, 5:18 AM
darius-dons.net.au updated this revision to Diff 59864.Jul 18 2019, 6:18 AM
darius-dons.net.au mentioned this in D20969: Add option to set umask before starting child process.Jul 18 2019, 6:23 AM
darius-dons.net.au updated this revision to Diff 59869.Jul 18 2019, 6:26 AM

Sorry for the noise, I can't drive Git..

Herald added a reviewer: manpages. · View Herald TranscriptJul 18 2019, 6:26 AM
rpokala added a comment.Jul 18 2019, 4:40 PM

Now this includes parts of D20969 😕

The core of this change -- sort and de-dupe getopt() and sort the cases -- is fine. Please try again with just that part, and leave the rest as part of D20969 as intended.

cem added a subscriber: cem.Jul 18 2019, 6:49 PM
darius-dons.net.au added a comment.Jul 18 2019, 11:42 PM
In D20983#455261, @rpokala wrote:

Now this includes parts of D20969 😕

The core of this change -- sort and de-dupe getopt() and sort the cases -- is fine. Please try again with just that part, and leave the rest as part of D20969 as intended.

As per IRC, it's a post D20969 version (although it predates the octal change so context is a bit misleading but the actual diff is right)

bcr accepted this revision as: manpages.Apr 29 2020, 11:28 AM
bcr added a subscriber: bcr.

The man page looks good. Don't forget to bump the .Dd when committing.

pstef accepted this revision.Aug 15 2021, 7:08 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
daemon/
3 lines
45 lines

Diff 59869

View Options

usr.sbin/daemon/daemon.8

Loading...
View Options

usr.sbin/daemon/daemon.c

Loading...