Page MenuHomeFreeBSD
Differential D20857

[PPC64] pseries: fix realmaxaddr calculation
ClosedPublic
Actions

Authored by luporl on Jul 4 2019, 7:07 PM.
Tags
None
Referenced Files
F166677002: D20857.id59533.diff
Sat, Aug 15, 11:36 AM
Unknown Object (File)
Fri, Aug 14, 4:41 AM
Unknown Object (File)
Wed, Aug 12, 6:50 PM
Unknown Object (File)
Tue, Aug 11, 11:42 AM
Unknown Object (File)
Tue, Aug 11, 9:17 AM
Unknown Object (File)
Mon, Aug 10, 10:47 PM
Unknown Object (File)
Mon, Aug 10, 7:00 PM
Unknown Object (File)
Mon, Aug 10, 5:16 AM
View All Files
Subscribers
alfredo
imp

Details

Reviewers
jhibbits
bdragon
nwhitehorn
Commits
rS349885: [PPC64] pseries: fix realmaxaddr calculation
Summary

On POWER9/pseries, QEMU passes several regions of memory,
instead of a single region containing all memory, as the
code was expecting.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25244
Build 23913: arc lint + arc unit

Event Timeline

luporl created this revision.Jul 4 2019, 7:07 PM
Harbormaster completed remote builds in B25202: Diff 59405.Jul 4 2019, 7:07 PM
bdragon added a comment.Jul 7 2019, 5:21 PM

Makes sense to me. That's the same sort of thing that chrp_mem_regions() is doing to determine it for its own purposes.

jhibbits added a comment.Jul 7 2019, 6:08 PM

Looks good overall. Just a couple nits..

sys/powerpc/aim/slb.c
419 ↗(On Diff #59405)

This looks to be a different patch altogether. I don't think it belongs in this change.

sys/powerpc/pseries/platform_chrp.c
150

realmaxaddr = MAX(off, realmaxaddr) should do the same thing.

luporl added inline comments.Jul 8 2019, 12:34 PM
sys/powerpc/aim/slb.c
419 ↗(On Diff #59405)

Ok, I'll commit this part separately.

sys/powerpc/pseries/platform_chrp.c
150

Right, I'll change this part to use MAX.

luporl updated this revision to Diff 59533.Jul 8 2019, 12:40 PM
luporl edited the summary of this revision. (Show Details)
  • Addressed jhibbits' comments
Harbormaster completed remote builds in B25244: Diff 59533.Jul 8 2019, 12:40 PM
luporl marked 2 inline comments as done.Jul 8 2019, 12:41 PM
jhibbits accepted this revision.Jul 8 2019, 4:24 PM
This revision is now accepted and ready to land.Jul 8 2019, 4:24 PM
Closed by commit rS349885: [PPC64] pseries: fix realmaxaddr calculation (authored by luporl). · Explain WhyJul 10 2019, 1:36 PM
This revision was automatically updated to reflect the committed changes.
luporl added a commit: rS349885: [PPC64] pseries: fix realmaxaddr calculation.
Herald added a subscriber: imp. · View Herald TranscriptJul 10 2019, 1:36 PM

Revision Contents
Changeset List

PathSize
sys/
powerpc/
pseries/
9 lines

Diff 59533

View Options

sys/powerpc/pseries/platform_chrp.c

Loading...