Page MenuHomeFreeBSD

ixgbe(4): Fix enabling/disabling and reconfiguration of queues
ClosedPublic

Authored by kgalazka on Jul 1 2019, 5:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 2, 10:57 AM
Unknown Object (File)
Mon, Jun 29, 9:50 PM
Unknown Object (File)
Mon, Jun 29, 8:00 PM
Unknown Object (File)
Thu, Jun 25, 3:00 AM
Unknown Object (File)
Tue, Jun 23, 4:27 AM
Unknown Object (File)
Sat, Jun 20, 4:56 AM
Unknown Object (File)
Wed, Jun 17, 2:53 AM
Unknown Object (File)
Fri, Jun 12, 2:50 PM

Details

Summary
  • Wrong order of casting and bit shift caused that enabling and disabling queues didn't work properly for queues number larger than 32. Use literals with right suffix instead.
  • TX ring tail address was not updated during reinitiailzation of TX structures. It could block sending traffic.
  • Also remove unused variables 'eims' and 'active_queues'.
Test Plan

Respectfully requesting our Validation Team to perform a test pass before committing.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25160
Build 23854: arc lint + arc unit