Page MenuHomeFreeBSD

ixgbe(4): Fix enabling/disabling and reconfiguration of queues
ClosedPublic

Authored by kgalazka on Jul 1 2019, 5:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 3, 5:37 AM
Unknown Object (File)
Wed, Apr 1, 1:48 AM
Unknown Object (File)
Sun, Mar 29, 10:10 AM
Unknown Object (File)
Sun, Mar 29, 12:09 AM
Unknown Object (File)
Tue, Mar 24, 2:23 AM
Unknown Object (File)
Fri, Mar 20, 9:17 PM
Unknown Object (File)
Thu, Mar 19, 2:50 PM
Unknown Object (File)
Thu, Mar 19, 12:56 AM

Details

Summary
  • Wrong order of casting and bit shift caused that enabling and disabling queues didn't work properly for queues number larger than 32. Use literals with right suffix instead.
  • TX ring tail address was not updated during reinitiailzation of TX structures. It could block sending traffic.
  • Also remove unused variables 'eims' and 'active_queues'.
Test Plan

Respectfully requesting our Validation Team to perform a test pass before committing.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25160
Build 23854: arc lint + arc unit