Page MenuHomeFreeBSD

acpi_iort: add some error handling
ClosedPublic

Authored by jchandra on May 26 2019, 11:31 PM.
Tags
None
Referenced Files
F132892521: D20416.id58101.diff
Mon, Oct 20, 10:20 PM
F132848841: D20416.id.diff
Mon, Oct 20, 11:50 AM
F132848840: D20416.id58969.diff
Mon, Oct 20, 11:50 AM
Unknown Object (File)
Sun, Oct 19, 9:26 PM
Unknown Object (File)
Sun, Oct 19, 7:32 AM
Unknown Object (File)
Fri, Oct 10, 10:43 AM
Unknown Object (File)
Sat, Sep 27, 11:58 AM
Unknown Object (File)
Fri, Sep 26, 3:55 AM
Subscribers

Details

Summary

Print warnings for bad kernel configuration (NUMA disabled with multiple domains) and for firmware errors (incorrect proximity domain entries).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 24520

Event Timeline

How frequently is srat_resolve_its_pxm called?

How frequently is srat_resolve_its_pxm called?

The SRAT has affinity entries for each memory segment, CPU and ITS block. Comes upto ~260 entries on my ThunderX2. We go into the main logic of srat_resolve_its_pxm() only for ITS blocks (2 entries).

I took a second look at this, and ran some more testing. I need to fix up a bug and add more comments.

Will update this diff.

Fix the check for warning (i > 1 now), fix up error message, and add a comment.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 24 2019, 9:25 PM
This revision was automatically updated to reflect the committed changes.