Differential D20290

Update Intel XL710 PF and VF drivers to version ixl-1.11.9 and ixlv-1.5.8
ClosedPublic
Actions

Authored by krzysztof.galazka_intel.com on May 17 2019, 12:58 PM.

Details

Reviewers

shurd
marius
jeffrey.e.pieper_intel.com

Group Reviewers

Intel Networking

Commits

rS349181: MFS r349163: ixl(4)/ixlv(4): Update Intel XL710 PF and VF drivers to ixl-1.11.9…
rS349163: ixl(4)/ixlv(4): Update Intel XL710 PF and VF drivers to ixl-1.11.9 and ixlv-1.5.

Summary

Update legacy (non-iflib) drivers in 11-STABLE branch with recent changes from out-of-tree version.

Major changes:

Support for new BASE-T device with additional link speeds (2.5G and 5G) and EEE.
Additional I2C access methods backported from ixl-iflib
FW LLDP Agent control with sysctl added also for X722 devices
MAC/VLAN filters handling refactored
Fix building and loading if_ixlv as KLD

Test Plan

Respectfully requesting our Validation Team to perform a test pass before committing.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24473
Build 23278: arc lint + arc unit

Event Timeline

krzysztof.galazka_intel.com created this revision.May 17 2019, 12:58 PM

Herald added a subscriber: ae. · View Herald TranscriptMay 17 2019, 12:58 PM

Harbormaster completed remote builds in B24274: Diff 57473.May 17 2019, 12:58 PM

Can you also update ixv driver? We discovered problems with ixv+VLANs on some KVM hosts with the stock driver, but the driver 1.5.15 from Intel's site works well.

krzysztof.galazka_intel.com added reviewers: shurd, marius.May 20 2019, 11:16 AM

Looks good to me; still needs re@ approval via the usual change request procedure for committing to stable/11 during the freeze, though.

Changes in Netmap support for ixl caused that ixlv cannot be loaded when built as KLD. Move ixl specific Netmap includes from ixl_txrx.c file, which is shared by ixl and ixlv, to ixl_pf_main.c which is used only by ixl.

Harbormaster completed remote builds in B24473: Diff 57840.May 24 2019, 2:08 PM

ixlv: Use old implementation of _msec_pause for reset flow to avoid panic.

This is a temporary solution. There is a bigger change in VF driver coming which will make this obsolete but it won't be ready on time for 11.3.

Harbormaster completed remote builds in B24696: Diff 58261.Jun 5 2019, 11:54 AM

jeffrey.e.pieper_intel.com accepted this revision.Jun 15 2019, 2:03 PM

This revision is now accepted and ready to land.Jun 15 2019, 2:03 PM