Create a separate interface for leaf-driver PCI IOV methods.
Leaf drivers should not import the PCI bus interface to add IOV handling.
Instead, move the IOV client methods to a separate kobj interface.
Details
Details
- Reviewers
jhb rstone - Group Reviewers
manpages - Commits
- rS283670: Create a separate kobj interface for leaf-driver PCI IOV methods.
- Not yet tested. I will do a universe build, but I don't have an easy way to runtime test this. I ran this by Ryan a while ago, but it would be nice to fix this sooner rather than later.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage
Event Timeline
Comment Actions
Note that I have a separate review to remove the executable property from the ixl source, but arcanist wouldn't let me upload the change to if_ixl.c without that change.
Comment Actions
Please update the PCI_INIT_IOV(9), PCI_ADD_VF(9) and PCI_UNINIT_IOV(9) manpages to document the new header file and reflect the new method names.
| sys/dev/pci/pci_iov.c | ||
|---|---|---|
| 703 | I think that you meant PCI_IOV_UNINIT() here | |
| sys/dev/pci/pci_iov_if.m | ||
|---|---|---|
| 3 | Should this file still remain "Copyright (c) 1998 Doug Rabson"? | |
Comment Actions
I believe that you need to update sys/modules/ixl/Makefile to document that the driver now depends on pci_iov_if.h as well
Comment Actions
Rebase.
- Rename manual pages.
- Catch up to manpage renames.
- Fix a IOV_UINIT -> PCI_IOV_UINIT I missed.
Comment Actions
Still need to do a universe build which should flesh out the ixl Makefile as well.
| sys/dev/pci/pci_iov_if.m | ||
|---|---|---|
| 3 | It should probably get a license from Ryan (or Ryan's employer) | |
| share/man/man9/PCI_IOV_ADD_VF.9 | ||
|---|---|---|
| 35 | Yes, though we generally don't require drivers to explicitly include foo_if.h headers. We normally have a wrapper header that includes them (e.g. sys/bus.h pulls in device_if.h and bus_if.h, and pcivar.h pulls in pci_if.h). I think it would be too disruptive to make pcivar.h pull his header in since we'd have to change umpteen different module Makefiles. One option I had thought about was creating a sys/dev/pci/pci_iov.h and moving the pci_iov_attach/detach wrapper functions into that. It would also have the nested include of pci_iov_if.h. | |
| sys/dev/pci/pci_iov_if.m | ||
| 3 | One oddity is that the pci_iov.c file (at least, haven't checked the others) has the phrase "All rights reserved" duplicated. | |
Comment Actions
- Move pci_iov_* prototypes into pci_iov.h and include pci_iov_if.h there.
- Fix ixl build.
| share/man/man9/PCI_IOV_ADD_VF.9 | ||
|---|---|---|
| 35 | Ok, I've done that. I think that in theory a driver would only need to include pci_iov.h and not | |
| sys/dev/pci/pci_iov.h | ||
|---|---|---|
| 3 | Er, you can omit the redundant "All rights reserved". :) | |