Create a separate interface for leaf-driver PCI IOV methods.
Leaf drivers should not import the PCI bus interface to add IOV handling.
Instead, move the IOV client methods to a separate kobj interface.
Paths
| Differential D2584 Authored by jhb on May 19 2015, 3:05 PM.
Tags None Referenced Files
Details
Summary Create a separate interface for leaf-driver PCI IOV methods. Leaf drivers should not import the PCI bus interface to add IOV handling. Test Plan
Diff Detail
Event Timelinejhb updated this object. Herald added a subscriber: imp. · View Herald TranscriptMay 19 2015, 3:06 PM2015-05-19 15:06:00 (UTC+0) jhb added a parent revision: D2583: Remove svn:executable property from ixl(4) source files..May 19 2015, 3:06 PM2015-05-19 15:06:57 (UTC+0) Comment ActionsNote that I have a separate review to remove the executable property from the ixl source, but arcanist wouldn't let me upload the change to if_ixl.c without that change. Comment Actions Please update the PCI_INIT_IOV(9), PCI_ADD_VF(9) and PCI_UNINIT_IOV(9) manpages to document the new header file and reflect the new method names.
Comment Actions I believe that you need to update sys/modules/ixl/Makefile to document that the driver now depends on pci_iov_if.h as well jhb marked an inline comment as done. jhb edited edge metadata. Comment ActionsRebase.
Herald added a reviewer: manpages. · View Herald TranscriptMay 28 2015, 3:25 PM2015-05-28 15:25:35 (UTC+0) Comment Actions Still need to do a universe build which should flesh out the ixl Makefile as well.
jhb added inline comments.
jhb marked an inline comment as done. jhb edited edge metadata. Comment Actions
rstone edited edge metadata. This revision is now accepted and ready to land.May 28 2015, 9:30 PM2015-05-28 21:30:14 (UTC+0) This revision now requires review to proceed.May 28 2015, 9:51 PM2015-05-28 21:51:49 (UTC+0) This revision is now accepted and ready to land.May 28 2015, 9:52 PM2015-05-28 21:52:30 (UTC+0) Closed by commit rS283670: Create a separate kobj interface for leaf-driver PCI IOV methods. (authored by jhb). · Explain WhyMay 28 2015, 10:01 PM2015-05-28 22:01:56 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 5748 share/man/man9/Makefile
share/man/man9/PCI_ADD_VF.9
share/man/man9/PCI_INIT_IOV.9
share/man/man9/PCI_IOV_ADD_VF.9
|
s/Service/service/g