Page MenuHomeFreeBSD
Differential D14858

arm64 linuxulator syscalls.master style review
ClosedPublic
Actions

Authored by emaste on Mar 26 2018, 8:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 22, 7:22 PM
Unknown Object (File)
Fri, Jan 17, 5:37 PM
Unknown Object (File)
Sun, Jan 12, 11:08 PM
Unknown Object (File)
Fri, Jan 10, 7:20 PM
Unknown Object (File)
Dec 23 2024, 6:57 AM
Unknown Object (File)
Dec 21 2024, 4:01 PM
Unknown Object (File)
Dec 12 2024, 6:59 PM
Unknown Object (File)
Dec 10 2024, 11:09 PM
View All 74 Files
Subscribers
andrew
brooks
dchagin
imp
trasz

Details

Reviewers
manu
brooks
dchagin
Commits
rS347186: Reformat arm64 linux syscalls.master per current style
Summary

This is a syscalls.master for arm64 linuxulator.

Existing Linuxulator (and other) syscalls.master files are a bit of a mess, with inconsistent wrapping at either 80, 81, about 100, or 108 characters. I have a few different style proposals here for discussion before applying to the whole file.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste created this revision.Mar 26 2018, 8:40 PM
Herald added a subscriber: andrew. · View Herald TranscriptMar 26 2018, 8:40 PM
brooks added a comment.Mar 26 2018, 11:46 PM

I have a strong preference for something like #1 where each argument goes on it's own line. That would greatly the ease of changes like D14285. It will also simplify review of type improvements such as adding const to path strings.

emaste updated this revision to Diff 57089.May 6 2019, 1:57 PM

Reformat arm64 linux syscalls.master per current style

Equivalent to rS339958 for sys/kern/syscalls.master.

Sponsored by: The FreeBSD Foundation

Herald added a reviewer: manu. · View Herald TranscriptMay 6 2019, 1:57 PM
Herald added a reviewer: brooks. · View Herald Transcript
dchagin accepted this revision.May 6 2019, 2:10 PM

I like it

This revision is now accepted and ready to land.May 6 2019, 2:10 PM
emaste added inline comments.May 6 2019, 2:33 PM
sys/arm64/linux/syscalls.master
1558–1559

One overzealous replacement here fixed in local tree - should be l_int pkey

Closed by commit rS347186: Reformat arm64 linux syscalls.master per current style (authored by emaste). · Explain WhyMay 6 2019, 4:07 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptMay 6 2019, 4:07 PM

Revision Contents
Changeset List

PathSize
sys/
arm64/
linux/
2031 lines

Diff 57089

View Options

sys/arm64/linux/syscalls.master

Loading...