Page MenuHomeFreeBSD

arm64 linuxulator syscalls.master style review
ClosedPublic

Authored by emaste on Mar 26 2018, 8:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 4:01 PM
Unknown Object (File)
Thu, Dec 12, 6:59 PM
Unknown Object (File)
Tue, Dec 10, 11:09 PM
Unknown Object (File)
Fri, Dec 6, 7:02 AM
Unknown Object (File)
Tue, Dec 3, 10:03 AM
Unknown Object (File)
Tue, Dec 3, 10:03 AM
Unknown Object (File)
Tue, Dec 3, 10:03 AM
Unknown Object (File)
Tue, Dec 3, 10:03 AM

Details

Summary

This is a syscalls.master for arm64 linuxulator.

Existing Linuxulator (and other) syscalls.master files are a bit of a mess, with inconsistent wrapping at either 80, 81, about 100, or 108 characters. I have a few different style proposals here for discussion before applying to the whole file.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

I have a strong preference for something like #1 where each argument goes on it's own line. That would greatly the ease of changes like D14285. It will also simplify review of type improvements such as adding const to path strings.

Reformat arm64 linux syscalls.master per current style

Equivalent to rS339958 for sys/kern/syscalls.master.

Sponsored by: The FreeBSD Foundation

This revision is now accepted and ready to land.May 6 2019, 2:10 PM
sys/arm64/linux/syscalls.master
1558–1559

One overzealous replacement here fixed in local tree - should be l_int pkey

This revision was automatically updated to reflect the committed changes.