Page MenuHomeFreeBSD
Differential D2586

Use fixed enum values for PMC_CLASSES().
ClosedPublic
Actions

Authored by jhb on May 19 2015, 4:02 PM.
Tags
None
Referenced Files
F161720590: D2586.diff
Mon, Jul 6, 5:44 AM
Unknown Object (File)
Sun, Jul 5, 2:47 AM
Unknown Object (File)
Sat, Jul 4, 9:54 AM
Unknown Object (File)
Fri, Jul 3, 11:48 PM
Unknown Object (File)
Fri, Jul 3, 4:11 AM
Unknown Object (File)
Fri, Jul 3, 1:18 AM
Unknown Object (File)
Wed, Jul 1, 11:26 PM
Unknown Object (File)
Fri, Jun 26, 9:15 AM
View All Files
Subscribers
gnn
imp

Details

Reviewers
emaste
davide
jhb
gnn
Commits
rS283120: Use fixed enum values for PMC_CLASSES().
Summary

Use fixed enum values for PMC_CLASSES().

This removes one of the frequent causes of ABI breakage when new CPU
types are added to hwpmc(4).

Test Plan
  • Haven't tested this yet, but will test that pmcstat and pmccontrol still work on an Intel system.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

jhb updated this revision to Diff 5482.May 19 2015, 4:02 PM
jhb retitled this revision from to Use fixed enum values for PMC_CLASSES()..
jhb updated this object.
jhb edited the test plan for this revision. (Show Details)
jhb added reviewers: emaste, davide.
Herald added subscribers: imp, gnn. · View Herald TranscriptMay 19 2015, 4:02 PM
davide accepted this revision.May 19 2015, 5:21 PM
davide edited edge metadata.

Sounds sensible.

sys/dev/hwpmc/hwpmc_mod.c
4639

should we panic here instead, or it is too drastic?

This revision is now accepted and ready to land.May 19 2015, 5:21 PM
emaste accepted this revision.May 19 2015, 5:31 PM
emaste edited edge metadata.

seems reasonable

sys/dev/hwpmc/hwpmc_mod.c
4639

too drastic I think

gnn accepted this revision.May 19 2015, 6:07 PM
gnn added a reviewer: gnn.
jhb updated this revision to Diff 5495.May 19 2015, 6:54 PM
jhb edited edge metadata.
  • Fix the class names output in dmesg.
This revision now requires review to proceed.May 19 2015, 6:54 PM
jhb accepted this revision.May 19 2015, 6:56 PM
jhb added a reviewer: jhb.

Tested and works fine on Intel at least modulo the comsetic fix for dmesg output I added.

This revision is now accepted and ready to land.May 19 2015, 6:56 PM
Closed by commit rS283120: Use fixed enum values for PMC_CLASSES(). (authored by jhb). · Explain WhyMay 19 2015, 6:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
lib/
libpmc/
17 lines
sys/
dev/
hwpmc/
18 lines
sys/
42 lines

Diff 5482

View Options

lib/libpmc/libpmc.c

Loading...
View Options

sys/dev/hwpmc/hwpmc_mod.c

Loading...
View Options

sys/sys/pmc.h

Loading...