Differential D19409

fortuna: Deduplicate kernel vs user includes
ClosedPublic
Actions

Authored by cem on Mar 1 2019, 1:58 AM.

Details

Reviewers

markm
markj
gordon
brooks
delphij
jmg

Group Reviewers

secteam
Core Team
O3: Kernel Random Numbers Generator	(Owns No Changed Paths)

Commits

rGf7c5c21f159f: fortuna: Deduplicate kernel vs user includes
rS344713: fortuna: Deduplicate kernel vs user includes

Summary

No functional change.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22816
Build 21904: arc lint + arc unit

Event Timeline

cem created this revision.Mar 1 2019, 1:58 AM

Harbormaster completed remote builds in B22816: Diff 54565.Mar 1 2019, 1:58 AM

Looks good to me.

This revision is now accepted and ready to land.Mar 1 2019, 9:55 AM

markj accepted this revision.Mar 1 2019, 3:52 PM

I guess I need blessing from secteam, so@, or core to touch dev/random. Can one of y'all quickly bless this non-functional change?

In the future, can I get blanket secteam approval to touch dev/random? I've read the Fortuna paper cover to cover and will get approval from at least markm@ on any random changes. I have a several other random and random-related changes pending I would like to get in, and I think I have a good track record re: not breaking random.