Page MenuHomeFreeBSD

Fix bhyve's NVMe Completion Queue entry values
ClosedPublic

Authored by chuck on Dec 31 2018, 6:58 PM.
Tags
Referenced Files
F106148257: D18703.id52551.diff
Thu, Dec 26, 4:50 AM
Unknown Object (File)
Thu, Dec 5, 12:39 AM
Unknown Object (File)
Tue, Nov 26, 5:01 PM
Unknown Object (File)
Oct 3 2024, 10:49 AM
Unknown Object (File)
Sep 17 2024, 9:26 PM
Unknown Object (File)
Sep 6 2024, 2:12 AM
Unknown Object (File)
Sep 3 2024, 5:33 AM
Unknown Object (File)
Sep 2 2024, 12:47 AM
Subscribers

Details

Summary

The function which processes Admin commands was not returning the
Command Specific value in Completion Queue Entry, Dword 0 (CDW0). This
effects commands such as Set Features, Number of Queues which returns
the number of queues supported by the device in CDW0. In this case, the
host would only ever create 1 queue pair (Number of Queues is zero based).
This also masked a bug in the queue counting logic.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

araujo added a reviewer: bhyve.

LGTM! Could you please set a MFC?

This revision is now accepted and ready to land.Jan 2 2019, 4:21 AM

LGTM! Could you please set a MFC?

Absolutely. I have one in the real commit message, but Differential didn't seem to like it in the summary.

LGTM! Could you please set a MFC?

Absolutely. I have one in the real commit message, but Differential didn't seem to like it in the summary.

Differential hates lines with foo : bar in them :(

This revision was automatically updated to reflect the committed changes.