Page MenuHomeFreeBSD
Differential D18703

Fix bhyve's NVMe Completion Queue entry values
ClosedPublic
Actions

Authored by chuck on Dec 31 2018, 6:58 PM.
Tags
Referenced Files
Unknown Object (File)
Wed, Jul 3, 11:51 AM
Unknown Object (File)
Sun, Jun 30, 10:26 AM
Unknown Object (File)
Thu, Jun 27, 10:33 PM
Unknown Object (File)
Thu, Jun 27, 4:36 PM
Unknown Object (File)
May 18 2024, 4:44 PM
Unknown Object (File)
Mar 7 2024, 11:34 PM
Unknown Object (File)
Feb 22 2024, 9:50 PM
Unknown Object (File)
Dec 20 2023, 4:03 AM
View All 28 Files
Subscribers
emaste

Details

Reviewers
imp
ken
araujo
rgrimes
Group Reviewers
bhyve
Commits
rS342762: Fix bhyve's NVMe Completion Queue entry values
Summary

The function which processes Admin commands was not returning the
Command Specific value in Completion Queue Entry, Dword 0 (CDW0). This
effects commands such as Set Features, Number of Queues which returns
the number of queues supported by the device in CDW0. In this case, the
host would only ever create 1 queue pair (Number of Queues is zero based).
This also masked a bug in the queue counting logic.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chuck created this revision.Dec 31 2018, 6:58 PM
Herald added a reviewer: rgrimes. · View Herald TranscriptDec 31 2018, 6:58 PM
Harbormaster completed remote builds in B21795: Diff 52460.Dec 31 2018, 6:58 PM
emaste added a subscriber: emaste.Jan 1 2019, 4:34 PM
araujo accepted this revision.Jan 2 2019, 4:21 AM
araujo added a reviewer: bhyve.

LGTM! Could you please set a MFC?

This revision is now accepted and ready to land.Jan 2 2019, 4:21 AM
imp accepted this revision.Jan 2 2019, 7:10 AM

lgtm

chuck added a comment.Jan 2 2019, 5:44 PM
In D18703#399189, @araujo wrote:

LGTM! Could you please set a MFC?

Absolutely. I have one in the real commit message, but Differential didn't seem to like it in the summary.

imp added a comment.Jan 2 2019, 6:21 PM
In D18703#399317, @chuck wrote:
In D18703#399189, @araujo wrote:

LGTM! Could you please set a MFC?

Absolutely. I have one in the real commit message, but Differential didn't seem to like it in the summary.

Differential hates lines with foo : bar in them :(

Closed by commit rS342762: Fix bhyve's NVMe Completion Queue entry values (authored by chuck). · Explain WhyJan 4 2019, 3:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
usr.sbin/
bhyve/
1 line

Diff 52551

View Options

head/usr.sbin/bhyve/pci_nvme.c

Loading...