Page MenuHomeFreeBSD
Differential D18630

gai_strerror() - Update string error messages according to RFC 3493
ClosedPublic
Actions

Authored by pfg on Dec 21 2018, 4:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 23, 8:02 AM
Unknown Object (File)
Mon, Oct 21, 3:57 PM
Unknown Object (File)
Mon, Oct 21, 3:57 PM
Unknown Object (File)
Mon, Oct 21, 3:57 PM
Unknown Object (File)
Mon, Oct 21, 3:57 PM
Unknown Object (File)
Mon, Oct 21, 3:40 PM
Unknown Object (File)
Mon, Oct 21, 2:15 PM
Unknown Object (File)
Oct 11 2024, 9:43 AM
View All 77 Files
Subscribers
bcr
bz
debdrup
imp

Details

Reviewers
ygy
bcr
pfg
Group Reviewers
network
docs
manpages
Summary

I noticed NetBSD started bogusly rreplacing EAI_NONAME with the deprecated EAI_NODATA, this was done because the haven't tagged EAI_NODATA as deprecated but also because the messsage for EAI_NONAME doesn't correspond well to EAI_NODATA.

Also, for a non.-developer end user something like "Invalid value for ai_flags" or "ai_family not supported" is not a very descriptive message.

Looking up more modern descriptions, I came up with the latest RFC 3493 with more up to date messages.

I just noticed we should also update the gai_strerror(3) man page, so that will come in a future revision.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 21689

Event Timeline

pfg created this revision.Dec 21 2018, 4:37 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 21 2018, 4:37 PM
Harbormaster completed remote builds in B21677: Diff 52232.Dec 21 2018, 4:37 PM
debdrup added a subscriber: debdrup.Dec 21 2018, 7:41 PM

Looks good to me.

ygy accepted this revision as: ygy.Dec 22 2018, 9:16 AM
This revision is now accepted and ready to land.Dec 22 2018, 9:16 AM
bcr accepted this revision.Dec 22 2018, 3:32 PM
bcr added a subscriber: bcr.

OK from the docs side.

pfg updated this revision to Diff 52253.Dec 23 2018, 12:49 AM

Keep the documentation consitent in the headers and manpage as well.
(Yes, I still have to update the manpage date before committing).

This revision now requires review to proceed.Dec 23 2018, 12:49 AM
Herald added a reviewer: manpages. · View Herald TranscriptDec 23 2018, 12:49 AM
Harbormaster completed remote builds in B21689: Diff 52253.Dec 23 2018, 12:49 AM
bcr accepted this revision.Dec 23 2018, 10:48 AM

OK from manpages.

This revision is now accepted and ready to land.Dec 23 2018, 10:48 AM
bz added a subscriber: bz.Dec 23 2018, 11:12 AM
bz added inline comments.
include/netdb.h
162

Comments end in '.'

lib/libc/net/gai_strerror.3
73

Do you think you could also add a "SEE ALSO" section with a reference to the RFC(s)?

pfg updated this revision to Diff 52263.Dec 23 2018, 5:49 PM
This revision now requires review to proceed.Dec 23 2018, 5:49 PM
Harbormaster completed remote builds in B21694: Diff 52263.Dec 23 2018, 5:49 PM
pfg marked 2 inline comments as done.Dec 23 2018, 5:50 PM

Thanks for the suggestions.

lib/libc/net/gai_strerror.3
73

I added STANDARDS, as in other pages.

pfg mentioned this in rS342379: gai_strerror() - Update string error messages according to RFC 3493..Dec 23 2018, 6:16 PM
pfg accepted this revision.Dec 23 2018, 6:21 PM
pfg marked an inline comment as done.

Commtted as r342379

This revision is now accepted and ready to land.Dec 23 2018, 6:21 PM
pfg closed this revision.Dec 23 2018, 6:21 PM

Revision Contents
Changeset List

PathSize
include/
18 lines
lib/
libc/
net/
28 lines
18 lines

Diff 52253

View Options

include/netdb.h

Loading...
View Options

lib/libc/net/gai_strerror.3

Loading...
View Options

lib/libc/net/gai_strerror.c

Loading...