Differential D18344

linuxulator: rename .s files to .S/.asm to use Clang IAS
ClosedPublic
Actions

Authored by emaste on Nov 26 2018, 7:45 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, May 14, 11:40 PM

	Unknown Object (File)
	Fri, May 10, 9:11 AM

	Unknown Object (File)
	Mon, May 6, 12:36 PM

	Unknown Object (File)
	Sun, May 5, 1:02 PM

	Unknown Object (File)
	Apr 20 2024, 1:52 PM

	Unknown Object (File)
	Apr 8 2024, 10:14 PM

	Unknown Object (File)
	Jan 28 2024, 1:10 AM

	Unknown Object (File)
	Jan 14 2024, 10:07 AM

View All 48 Files

Subscribers

Details

Reviewers

imp
dim
manu

Commits

rS350451: linuxulator: rename linux_locore.s to .asm

Summary

As part of the migration away from obsolete binutils we want to retire GNU as. Most assembly files used on amd64 have a .S extension and are assembled with Clang's integrated assembler. We also have a rule for .asm files, which pass -x assembler-with-cpp to the Clang driver.

The Linuxulator has bespoke rules for invoking the compiler driver to assemble .s files and was already using Clang's IAS, but rename the assembly files for consistency.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste created this revision.Nov 26 2018, 7:45 PM

Herald added a reviewer: manu. · View Herald TranscriptNov 26 2018, 7:45 PM

Herald added a subscriber: andrew. · View Herald Transcript

emaste mentioned this in D18369: stand/i386: rename .s to .S to use Clang IAS.Dec 3 2018, 7:24 PM

dchagin removed a reviewer: dchagin.Apr 30 2019, 6:24 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 30 2019, 5:18 PM

Closed by commit rS350451: linuxulator: rename linux_locore.s to .asm (authored by emaste). · Explain Why

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rS350451: linuxulator: rename linux_locore.s to .asm.

trasz mentioned this in rS364552: MFC r350451 by emaste:.Aug 23 2020, 9:39 PM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

linux/

	linux_locore.asm
	linux_locore.s

	linux_support.S
	linux_support.s

linux_support.s

linux32/

	linux32_locore.asm
	linux32_locore.s

linux32_locore.s

	linux32_support.S
	linux32_support.s

linux32_support.s

arm64/

linux/

	linux_locore.asm
	linux_locore.s

	linux_support.S
	linux_support.s

linux_support.s

conf/

2 lines

2 lines

i386/

linux/

	linux_locore.S
	linux_locore.s

modules/

linux/

2 lines

linux64/

4 lines

Diff 51132

sys/amd64/linux/linux_locore.asm

Loading...

sys/amd64/linux/linux_locore.s

Loading...

sys/amd64/linux/linux_support.S

Loading...

sys/amd64/linux/linux_support.s

Loading...

sys/amd64/linux32/linux32_locore.asm

Loading...

sys/amd64/linux32/linux32_locore.s

Loading...

sys/amd64/linux32/linux32_support.S

Loading...

sys/amd64/linux32/linux32_support.s

Loading...

sys/arm64/linux/linux_locore.asm

Loading...

sys/arm64/linux/linux_locore.s

Loading...

sys/arm64/linux/linux_support.S

Loading...

sys/arm64/linux/linux_support.s

Loading...

sys/conf/files.amd64

Loading...

sys/conf/files.i386

Loading...

sys/i386/linux/linux_locore.S

Loading...

sys/i386/linux/linux_locore.s

Loading...

sys/modules/linux/Makefile

Loading...

sys/modules/linux64/Makefile

Loading...