Page MenuHomeFreeBSD

stand/i386: rename .s to .S to use Clang IAS
ClosedPublic

Authored by emaste on Wed, Nov 28, 3:55 PM.

Details

Summary

As part of the migration away from obsolete binutils we want to retire GNU as. Most assembly files used on amd64 have a .S extension and (via rules in share/mk/bsd.suffixes.mk) are assembled with Clang's Integrated Assembler (IAS). Rename files in stand/i386 to .S to use the integrated assembler.

Clang's IAS supports the defsym option (via -Wa,) but only with one dash, not two. As both -defsym and --defsym are accepted by GNU as, use the former.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emaste created this revision.Wed, Nov 28, 3:55 PM
tsoome accepted this revision.Mon, Dec 3, 7:05 PM
This revision is now accepted and ready to land.Mon, Dec 3, 7:05 PM
This revision was automatically updated to reflect the committed changes.
imp added a comment.Mon, Dec 3, 7:21 PM

I looked at this on my phone a few days ago and meant to stamp it with LGTM when I got back to my computer, but that fell through the cracks.

emaste added a comment.Mon, Dec 3, 7:24 PM
In D18369#392138, @imp wrote:

I looked at this on my phone a few days ago and meant to stamp it with LGTM when I got back to my computer, but that fell through the cracks.

OK, thanks for the followup!

On amd64 there's one more change ready to go in D18344, then just skein_block_asm.s to deal with.