Handle vm_phys returning NULL in vm_page_alloc()
Needs ReviewPublic
Actions

Authored by adrian on Apr 30 2015, 5:12 AM.

Details

Reviewers

kib
kmacy
alc

Group Reviewers

manpages

Summary

When using VM domains, it's possible that unbalanced VM domain memory pressure
(or even different sized memory domains) may lead to the global VM thresholds saying
there's memory, but vm_phys returning NULL. In this instance, a NULL page
is dereferenced, and things blow up.

This change has it return NULL, which prevents the system from crashing.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

adrian updated this revision to Diff 5095.Apr 30 2015, 5:12 AM

adrian retitled this revision from to Handle vm_phys returning NULL in vm_page_alloc().

adrian updated this object.

adrian edited the test plan for this revision. (Show Details)

adrian added reviewers: alc, kmacy, kib.

Herald added a reviewer: manpages. · View Herald TranscriptApr 30 2015, 5:12 AM

Herald added a subscriber: imp. · View Herald Transcript

Is this something that happens in the stock sources, or the situation to occur requires patches to limit allocation of a new page to the specific domain ? I think that if applied to the HEAD, it would defeat the KASSERT(m != NULL) right after the cited block, and break invariants.

I haven't triggered it in stock sources - this happens in my VM policy branch. There are some use cases where the memory must come from a particular domain, so VM phys memory allocation can get unbalanced.

rpaulo added a subscriber: rpaulo.Apr 30 2015, 4:27 PM

kmacy resigned from this revision.Apr 11 2018, 12:07 AM

I think that this change should be abandoned.

@adrian can this be closed/abandoned?

Revision Contents
Changeset List

Path

Size

sys/

vm/

vm_page.c

15 lines

Diff 5095

View Options

Handle vm_phys returning NULL in vm_page_alloc()Needs ReviewPublicActions