Page MenuHomeFreeBSD

Add a regression test for D17914.
ClosedPublic

Authored by markj on Nov 9 2018, 6:01 PM.
Tags
None
Referenced Files
F112681983: D17926.diff
Fri, Mar 21, 9:29 AM
Unknown Object (File)
Mon, Mar 17, 2:02 AM
Unknown Object (File)
Tue, Mar 11, 3:35 AM
Unknown Object (File)
Sun, Mar 9, 9:51 PM
Unknown Object (File)
Fri, Feb 28, 6:19 PM
Unknown Object (File)
Fri, Feb 21, 6:02 AM
Unknown Object (File)
Thu, Feb 20, 1:39 PM
Unknown Object (File)
Thu, Feb 20, 2:05 AM
Subscribers

Details

Summary

I will address the XXX comment and add more test cases, but figured I'd
put this up now.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • Don't hardcode loopback ifname or address.
  • Add a test for fragments with payload length 0.
  • Add tests for D17922
  • Use random IP IDs

Extend ip_reass__multiple_last_fragments

This test should really attempt to read the reassembled packet and verify its
contents. I'll try extending it along those lines, but I think that can be
handled in a separate commit.

LGTM after a somewhat cursory review.

This revision is now accepted and ready to land.Nov 10 2018, 8:21 PM
This revision was automatically updated to reflect the committed changes.