Page MenuHomeFreeBSD
Differential D17926

Add a regression test for D17914.
ClosedPublic
Actions

Authored by markj on Nov 9 2018, 6:01 PM.
Tags
None
Referenced Files
F161738041: D17926.diff
Mon, Jul 6, 9:58 AM
Unknown Object (File)
Mon, Jun 8, 9:31 PM
Unknown Object (File)
May 27 2026, 4:37 PM
Unknown Object (File)
May 27 2026, 3:40 PM
Unknown Object (File)
May 27 2026, 2:58 PM
Unknown Object (File)
May 27 2026, 7:46 AM
Unknown Object (File)
May 27 2026, 6:26 AM
Unknown Object (File)
May 26 2026, 1:45 PM
View All Files
Subscribers
asomers
imp

Details

Reviewers
jtl
emaste
glebius
Commits
rS340485: Add regression tests for r340313 and r340483.
Summary

I will address the XXX comment and add more test cases, but figured I'd
put this up now.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20733
Build 20142: arc lint + arc unit

Event Timeline

markj created this revision.Nov 9 2018, 6:01 PM
Herald added a subscriber: asomers. · View Herald TranscriptNov 9 2018, 6:01 PM
Harbormaster completed remote builds in B20723: Diff 50221.Nov 9 2018, 6:01 PM
markj added reviewers: jtl, emaste, glebius.Nov 9 2018, 6:02 PM
markj updated this revision to Diff 50235.Nov 9 2018, 9:23 PM
  • Don't hardcode loopback ifname or address.
  • Add a test for fragments with payload length 0.
Harbormaster completed remote builds in B20730: Diff 50235.Nov 9 2018, 9:23 PM
markj updated this revision to Diff 50237.Nov 9 2018, 9:57 PM
  • Add tests for D17922
  • Use random IP IDs
Harbormaster completed remote builds in B20732: Diff 50237.Nov 9 2018, 9:57 PM
markj updated this revision to Diff 50238.Nov 9 2018, 10:09 PM

Extend ip_reass__multiple_last_fragments

This test should really attempt to read the reassembled packet and verify its
contents. I'll try extending it along those lines, but I think that can be
handled in a separate commit.

Harbormaster completed remote builds in B20733: Diff 50238.Nov 9 2018, 10:09 PM
emaste accepted this revision.Nov 10 2018, 8:21 PM

LGTM after a somewhat cursory review.

This revision is now accepted and ready to land.Nov 10 2018, 8:21 PM
Closed by commit rS340485: Add regression tests for r340313 and r340483. (authored by markj). · Explain WhyNov 16 2018, 7:04 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 16 2018, 7:04 PM

Revision Contents
Changeset List

PathSize
tests/
sys/
netinet/
3 lines
381 lines

Diff 50238

View Options

tests/sys/netinet/Makefile

Loading...
View Options

tests/sys/netinet/ip_reass_test.c

Loading...