Page MenuHomeFreeBSD

Add a regression test for D17914.
ClosedPublic

Authored by markj on Nov 9 2018, 6:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 12:07 AM
Unknown Object (File)
Oct 23 2024, 2:23 AM
Unknown Object (File)
Oct 23 2024, 2:23 AM
Unknown Object (File)
Oct 23 2024, 2:23 AM
Unknown Object (File)
Oct 23 2024, 2:23 AM
Unknown Object (File)
Oct 23 2024, 2:22 AM
Unknown Object (File)
Oct 23 2024, 2:22 AM
Unknown Object (File)
Oct 23 2024, 2:11 AM
Subscribers

Details

Summary

I will address the XXX comment and add more test cases, but figured I'd
put this up now.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20733
Build 20142: arc lint + arc unit

Event Timeline

  • Don't hardcode loopback ifname or address.
  • Add a test for fragments with payload length 0.
  • Add tests for D17922
  • Use random IP IDs

Extend ip_reass__multiple_last_fragments

This test should really attempt to read the reassembled packet and verify its
contents. I'll try extending it along those lines, but I think that can be
handled in a separate commit.

LGTM after a somewhat cursory review.

This revision is now accepted and ready to land.Nov 10 2018, 8:21 PM
This revision was automatically updated to reflect the committed changes.