crossbuild: Allow bootstrapping libopenbsd on Linux
ClosedPublic
Actions

Authored by arichardson on Feb 7 2018, 4:04 PM.

Details

Reviewers

emaste
imp
bdrewery
jhb
brooks

Commits

rS341515: Allow bootstrapping libopenbsd on Linux

Summary

The getdtablecount.c file won't compile on Linux but it seems like none of
the bootstrap tools actually need it.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20566
Build 19987: arc lint + arc unit

Event Timeline

arichardson created this revision.Feb 7 2018, 4:04 PM

Harbormaster completed remote builds in B14845: Diff 39003.Feb 7 2018, 4:04 PM

Simplify and remove .MAKE.OS check

Harbormaster completed remote builds in B20565: Diff 49872.Nov 1 2018, 11:40 AM

Fix typo in comment

Harbormaster completed remote builds in B20566: Diff 49873.Nov 1 2018, 11:41 AM

ping?

I don't really like this, but given that any failure should be fairly straightforward to track down OK.

(I'd probably prefer some sort of #ifdef linux in getdtablecount.c itself with a #warning and a stub implementation.)

This revision is now accepted and ready to land.Nov 22 2018, 11:29 PM

emaste added a subscriber: brooks.Nov 22 2018, 11:29 PM

This seems fine, especially since libopenbsd is an INTERNALLIB.

Closed by commit rS341515: Allow bootstrapping libopenbsd on Linux (authored by arichardson). · Explain WhyDec 5 2018, 10:59 AM

This revision was automatically updated to reflect the committed changes.

In D14244#388189, @emaste wrote:

I don't really like this, but given that any failure should be fairly straightforward to track down OK.

(I'd probably prefer some sort of #ifdef linux in getdtablecount.c itself with a #warning and a stub implementation.)

+1
Reviewed by me too (I think I'm late)

Revision Contents
Changeset List

Path

Size

lib/

libopenbsd/

Makefile

9 lines

Diff 49873

View Options

crossbuild: Allow bootstrapping libopenbsd on LinuxClosedPublicActions