Page MenuHomeFreeBSD
Differential D14244

crossbuild: Allow bootstrapping libopenbsd on Linux
ClosedPublic
Actions

Authored by arichardson on Feb 7 2018, 4:04 PM.
Tags
None
Referenced Files
F168256890: D14244.id49873.diff
Thu, Aug 27, 5:28 AM
Unknown Object (File)
Tue, Aug 25, 9:21 PM
Unknown Object (File)
Tue, Aug 25, 9:22 AM
Unknown Object (File)
Tue, Aug 25, 8:26 AM
Unknown Object (File)
Sat, Aug 22, 1:23 PM
Unknown Object (File)
Fri, Aug 21, 2:17 PM
Unknown Object (File)
Fri, Aug 21, 12:22 PM
Unknown Object (File)
Fri, Aug 21, 11:59 AM
View All Files
Subscribers
brooks

Details

Reviewers
emaste
imp
bdrewery
jhb
brooks
Commits
rS341515: Allow bootstrapping libopenbsd on Linux
Summary

The getdtablecount.c file won't compile on Linux but it seems like none of
the bootstrap tools actually need it.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arichardson created this revision.Feb 7 2018, 4:04 PM
Harbormaster completed remote builds in B14845: Diff 39003.Feb 7 2018, 4:04 PM
arichardson updated this revision to Diff 49872.Nov 1 2018, 11:40 AM

Simplify and remove .MAKE.OS check

Harbormaster completed remote builds in B20565: Diff 49872.Nov 1 2018, 11:40 AM
arichardson updated this revision to Diff 49873.Nov 1 2018, 11:41 AM

Fix typo in comment

Harbormaster completed remote builds in B20566: Diff 49873.Nov 1 2018, 11:41 AM
arichardson added a comment.Nov 18 2018, 9:37 AM

ping?

emaste accepted this revision.Nov 22 2018, 11:29 PM

I don't really like this, but given that any failure should be fairly straightforward to track down OK.

(I'd probably prefer some sort of #ifdef linux in getdtablecount.c itself with a #warning and a stub implementation.)

This revision is now accepted and ready to land.Nov 22 2018, 11:29 PM
emaste added a subscriber: brooks.Nov 22 2018, 11:29 PM
brooks accepted this revision.Nov 26 2018, 7:42 PM

This seems fine, especially since libopenbsd is an INTERNALLIB.

Closed by commit rS341515: Allow bootstrapping libopenbsd on Linux (authored by arichardson). · Explain WhyDec 5 2018, 10:59 AM
This revision was automatically updated to reflect the committed changes.
bdrewery added a comment.Dec 5 2018, 7:49 PM
In D14244#388189, @emaste wrote:

I don't really like this, but given that any failure should be fairly straightforward to track down OK.

(I'd probably prefer some sort of #ifdef linux in getdtablecount.c itself with a #warning and a stub implementation.)

+1
Reviewed by me too (I think I'm late)

Revision Contents
Changeset List

PathSize
head/
lib/
libopenbsd/
9 lines

Diff 51598

View Options

head/lib/libopenbsd/Makefile

Loading...