Page MenuHomeFreeBSD

crossbuild: Allow bootstrapping libopenbsd on Linux
ClosedPublic

Authored by arichardson on Feb 7 2018, 4:04 PM.
Tags
None
Referenced Files
F132990194: D14244.id49872.diff
Tue, Oct 21, 9:11 PM
F132989971: D14244.id49873.diff
Tue, Oct 21, 9:09 PM
F132986649: D14244.id39003.diff
Tue, Oct 21, 8:29 PM
F132985618: D14244.id.diff
Tue, Oct 21, 8:18 PM
F132985616: D14244.id51598.diff
Tue, Oct 21, 8:18 PM
F132966343: D14244.id51598.diff
Tue, Oct 21, 3:34 PM
Unknown Object (File)
Tue, Oct 21, 8:53 AM
Unknown Object (File)
Sun, Oct 19, 11:12 PM
Subscribers

Details

Summary

The getdtablecount.c file won't compile on Linux but it seems like none of
the bootstrap tools actually need it.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Simplify and remove .MAKE.OS check

I don't really like this, but given that any failure should be fairly straightforward to track down OK.

(I'd probably prefer some sort of #ifdef linux in getdtablecount.c itself with a #warning and a stub implementation.)

This revision is now accepted and ready to land.Nov 22 2018, 11:29 PM

This seems fine, especially since libopenbsd is an INTERNALLIB.

This revision was automatically updated to reflect the committed changes.

I don't really like this, but given that any failure should be fairly straightforward to track down OK.

(I'd probably prefer some sort of #ifdef linux in getdtablecount.c itself with a #warning and a stub implementation.)

+1
Reviewed by me too (I think I'm late)